Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Playground blueprint and zip file. #3

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

ndiego
Copy link
Contributor

@ndiego ndiego commented Mar 22, 2024

The PR adds the zip file for the block to githubusercontent, which can then be used in a Playground blueprint. The direct zip file cannot be used due to CORS errors.

Comment on lines 10 to 19
{
"step": "installPlugin",
"pluginZipFile": {
"resource": "wordpress.org/plugins",
"slug": "gutenberg"
},
"options": {
"activate": true
}
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need GB? (I'm fine with it, just genuinely curious 🙂)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess not. That was just a default in all the blueprints I was testing 😅 I'll remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set!

Copy link
Owner

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds the zip file for the block to githubusercontent, which can then be used in a Playground blueprint. The direct zip file cannot be used due to CORS errors.

TIL about CORS being supported by githubusercontent, but not by GH releases! Bummer, but thank you for the workaround.

LGTM. I had one question about the GB dependency, but we can address that after the fact.

@ockham
Copy link
Owner

ockham commented Mar 25, 2024

Aside, I wonder if the GH action that's used e.g. in the wordpress-develop repo to post comments with links to the Playground for testing (e.g.) is reusable and could be used in repos like this one to easily test a PR for a plugin 🤔

cc/ @adamziel 👋😄

@ndiego
Copy link
Contributor Author

ndiego commented Mar 25, 2024

Aside, I wonder if the GH action that's used e.g. in the wordpress-develop repo to post comments with links to the Playground for testing (WordPress/wordpress-develop#6278 (comment)) is reusable and could be used in repos like this one to easily test a PR for a plugin 🤔

It would be very interesting to learn how that works.

@adamziel
Copy link

@ockham It should be reusable with some manual copy&paste&adjust work. I'd love to turn it into a GitHub App that could be installed in any repo and configured with an artifact name and a default message. Would you be up for exploring that? It would help many projects, e.g. this repo, Gutenberg, Woo just to name a few.

@adamziel
Copy link

I just started this issue to discuss a generic solution: WordPress/wordpress-playground#1138

@ndiego
Copy link
Contributor Author

ndiego commented Mar 25, 2024

@ockham if this looks ok, are you able to merge this? I plan to publish the Block Hooks article later today. Thanks! 🙏

@ockham ockham merged commit b2563d4 into ockham:trunk Mar 25, 2024
@ockham
Copy link
Owner

ockham commented Mar 25, 2024

@ockham It should be reusable with some manual copy&paste&adjust work. I'd love to turn it into a GitHub App that could be installed in any repo and configured with an artifact name and a default message. Would you be up for exploring that? It would help many projects, e.g. this repo, Gutenberg, Woo just to name a few.

I'd be interested to explore that! I'm just not sure how much I'll be able to contribute to this in the short term, as I'm still pretty busy with tying up a number of loose ends 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants