-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Playground blueprint and zip file. #3
Conversation
_playground/blueprint.json
Outdated
{ | ||
"step": "installPlugin", | ||
"pluginZipFile": { | ||
"resource": "wordpress.org/plugins", | ||
"slug": "gutenberg" | ||
}, | ||
"options": { | ||
"activate": true | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need GB? (I'm fine with it, just genuinely curious 🙂)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess not. That was just a default in all the blueprints I was testing 😅 I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All set!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR adds the zip file for the block to githubusercontent, which can then be used in a Playground blueprint. The direct zip file cannot be used due to CORS errors.
TIL about CORS being supported by githubusercontent, but not by GH releases! Bummer, but thank you for the workaround.
LGTM. I had one question about the GB dependency, but we can address that after the fact.
It would be very interesting to learn how that works. |
@ockham It should be reusable with some manual copy&paste&adjust work. I'd love to turn it into a GitHub App that could be installed in any repo and configured with an artifact name and a default message. Would you be up for exploring that? It would help many projects, e.g. this repo, Gutenberg, Woo just to name a few. |
I just started this issue to discuss a generic solution: WordPress/wordpress-playground#1138 |
@ockham if this looks ok, are you able to merge this? I plan to publish the Block Hooks article later today. Thanks! 🙏 |
I'd be interested to explore that! I'm just not sure how much I'll be able to contribute to this in the short term, as I'm still pretty busy with tying up a number of loose ends 😅 |
The PR adds the zip file for the block to githubusercontent, which can then be used in a Playground blueprint. The direct zip file cannot be used due to CORS errors.