-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: Add ohw19 built files from master to source #315
base: source
Are you sure you want to change the base?
Conversation
… in a new set of built pages
✅ Deploy Preview for oceanhackweek-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…. Also changed ohw22 links to relative links
It looks like we may want to put the built files into |
Thanks for that suggestion. I'll test it out and update this PR if it looks promising. |
I placed the It didn't work. It looks like
Without adding I assume |
Using a fresh conda env with Py311, a recent |
…ension, for a test not pursued
…tlify previous continue to work for now
I've pushed the setup I described in my previous comment. The Let's not merge this just yet, though. I'd like to focus my OHW time right now on getting OHW24 content off the ground. Also, it'll probably be more efficient to bring in the old ohw20 & ohw21 pages into this PR too. ohw18 is best handled in a separate PR, b/c the files reside in a different repo (see #316). |
... for inclusion as-is in a new set of built pages. See #314.
This PR is not intended to be merged. I'm creating it to continue the discussion in #314, to share the outcome of the current changes.
As mentioned there, the ohw19 index page is overwriting the main site index page.Update 1: I don't know what I did, but the index-page overwrite is no longer a problem! I've now updated the links to ohw19 pages in the Past OHW Events page, but the ohw19 links are not built. Here's one of the warnings:
This has to do with files in
html_extra_path
being handled differently. Apparently links are not generated as expected -- see here. But I haven't found a solution. Note that I tried both/ohw19/
and../ohw19/
, but it made no difference.Update 2: A simple solution to the link generation problem would be to use "external", absolute url's (eg, https://oceanhackweek.org/ohw19/index.html) instead of relative url's. It makes local debugging harder, but it's very easy.