-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize Resources, top menu, and ohw23 & ohw22 menus #261
Conversation
✅ Deploy Preview for oceanhackweek-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Once we've merged this PR, we can tackle PR #260 |
For the OHW22 nav, I think that Sphinx only wants to render toctrees that are part of the global toctree hiearchy, so adding the OHW22 index explicitly to another tree should do it. # on about/pasthackweeks.md ?
```{toctree}
:maxdepth: 1
../ohw22/index.md
```
The tutorials are linked via a git submodule which is defined here, but there is an incantation for adding them that I don't remember at the moment, but here is the PR when I set things up that way. There are a whole bunch of other errors that I think correspond to changed pages that are probably worth going through. |
…Plus other ohw22 cleanup
…Plus schedule page fixes
Thanks @abkfenris ! I've pushed several commits that:
The "tutorials-index" git submodule stuff for ohw23 is still pending. @abkfenris I'll let you take care of that. How do things look now? FYI Old content is still largely not updated, with minor exceptions. I also for the most part haven't added any new warnings ("admonitions") about old content in individual pages. Once the page organization stabilizes and this PR is merged, maybe @alisonpchase and @btupper can tackle that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few pages that have been moved from resources to event specific pages and duplicated. I think we can keep them in resources and use admonitions (and maybe tabs) to call out any event specifics.
ohw22/logistics/getting_help.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like most of getting help and the projects info right now are more general and could live in resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mix of general and event-specific content seemed more even in getting help and projects info. It's fair to say that both follow a template where some specific information (Slack channel names, dates, brief descriptions, etc) would be customized in each event. For the getting help page, the text is the same except for a bunch of Slack channel names that are spread throughout the page. I think that makes the use of admonitions too crowded / bloated.
Anyways, I'll take another look.
…vent project pages
There are still some errors that could be fixed w/o too much trouble. Maybe later! |
|
The ohw23 tutorials submodule linkage will be done later, in a separate PR. See #263 |
Substantial reorganization of pages and menus.
resources
folder was moved and duplicated to bothohw23
andohw22
: thelogistics
andprojects
folderstutorials
andtutorials-index
folders fromohw22
toohw23
. So, right now ohw23 tutorials is a stub, pointing to ohw22 tutorialsA bunch of event-specific content will need to be updated. Let's at least add warnings (admonitions) where they're found, while we do the updates.
@abkfenris :
ohw-tutorials
repo into thetutorials
folder. So, that part will be broken forohw23
This PR is definitely not intended to be merged as is. Let's use it to discuss the reorganization and suggest changes large or small.