-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] support slb connection rebalance in ODP mode #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IHEII
reviewed
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there :D
shenyunlong
force-pushed
the
LoadBalance
branch
2 times, most recently
from
October 17, 2023 13:54
53550fa
to
2396f1d
Compare
shenyunlong
force-pushed
the
LoadBalance
branch
from
October 17, 2023 14:05
2396f1d
to
2c029ee
Compare
WeiXinChan
reviewed
Oct 18, 2023
WeiXinChan
reviewed
Oct 18, 2023
WeiXinChan
reviewed
Oct 18, 2023
WeiXinChan
reviewed
Oct 18, 2023
WeiXinChan
reviewed
Oct 18, 2023
WeiXinChan
reviewed
Oct 18, 2023
WeiXinChan
reviewed
Oct 18, 2023
LGTM |
1 similar comment
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
support SLB LoadBalance and MaxConnectionAge in ODP mode
Solution Description
supply two configuration item to support connection balance in ODP mode(i.e. this two configuration item only works in ODP mode):
MaxConnectionAge
: the maximum survival time of connection in table client, after connections expired, client will reconnect these expired connections in smoothEnableSLBLoadBalance
: if this option set to true, which means client will get SLB addresses from DNS, and monitor the change of SLB addresses from DNS, every connection is connect to one SLB address directly in round-robin way, when SLB addresses changed, client will reconnect according to new SLB addresses