Enable mlx in documentSelector and a few small features #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesnx
changed the title
…into include-mlx-documentSelector * 'master' of github.com:/ocamllabs/vscode-ocaml-platform: (36 commits) Bump esbuild from 0.25.11 to 0.25.12 (ocamllabs#1996) Lock file maintenance flake.lock: Update (ocamllabs#1995) Mise Bump tar from 7.5.1 to 7.5.2 (ocamllabs#1994) Bump @tsconfig/strictest from 2.0.6 to 2.0.7 (ocamllabs#1993) Bump @types/node from 24.9.1 to 24.9.2 (ocamllabs#1991) Bump @biomejs/biome from 2.3.1 to 2.3.2 (ocamllabs#1992) Bump @biomejs/biome from 2.3.0 to 2.3.1 (ocamllabs#1989) Bump actions/upload-artifact from 4 to 5 (ocamllabs#1988) Bump actions/download-artifact from 5 to 6 (ocamllabs#1987) Update opam files Prepare 1.32.4 (ocamllabs#1986) Lock file maintenance Fix keybinding when conditions and unsupported language filters (ocamllabs#1985) Remove `ocaml.ocamllex` from type-dependent command conditions (ocamllabs#1984) Fix editor focus condition for interface keybindings (ocamllabs#1983) flake.lock: Update (ocamllabs#1982) Bump ocamlformat from 0.27.0 to 0.28.1 (ocamllabs#1981) Bump @biomejs/biome from 2.2.7 to 2.3.0 (ocamllabs#1980) ...
Contributor
Author
|
Updated the PR and resolved the conflicts with #1985. I endup with |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
smorimoto
reviewed
Nov 2, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/ast_editor.ml:87
- The
get_pp_pathfunction handles.mlxfiles asStructureOcaml(line 71) but the preprocessing path generation at line 87 only strips.mlsuffix. This will fail for.mlxfiles sinceString.chop_suffix_exnwill raise an exception when the file doesn't have a.mlextension. Consider adding a case to handle.mlx` files or updating the pattern match to handle both extensions.
| Structure `Ocaml ->
Some (String.chop_suffix_exn ~suffix:".ml" relative ^ ".pp.ml")
src/switch_impl_intf.ml:12
- The comment on line 12 states 'If the source file was a .ml or .re' but the code now also supports .mlx files (line 8). Update the comment to include .mlx files.
(* If the source file was a .ml or .re, infer the interface *)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
smorimoto
approved these changes
Nov 3, 2025
davesnx
commented
Nov 3, 2025
| { | ||
| "command": "ocaml.search-by-type", | ||
| "when": "editorLangId == ocaml || editorLangId == ocaml.interface || editorLangId == reason" | ||
| "when": "editorLangId == ocaml || editorLangId == ocaml.interface || editorLangId == reason || editorLangId == ocaml.mlx" |
Contributor
Author
There was a problem hiding this comment.
Here we could probably add editorTextFocus for correctness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables ocaml.mlx in a few places:
I leaves a few todos: