Skip to content

make parmap depend on conf-autoconf #5995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2016
Merged

Conversation

UnixJunkie
Copy link
Contributor

No description provided.

@camelus
Copy link
Contributor

camelus commented Mar 15, 2016

✅ All lint checks passed a229c67
  • These packages passed lint tests: parmap.0.9.1, parmap.1.0-rc1, parmap.1.0-rc2, parmap.1.0-rc3, parmap.1.0-rc4, parmap.1.0-rc5, parmap.1.0-rc6, parmap.1.0-rc7

✅ Installability check (4611 → 4611)

@yallop
Copy link
Member

yallop commented Mar 15, 2016

/cc @rdicosmo.

@UnixJunkie
Copy link
Contributor Author

all green in travis and camelus now

@dbuenzli
Copy link
Contributor

all green in travis and camelus now

@UnixJunkie AFAIK opam's maintainers are not color blind. Please avoid generating useless notifications.

@UnixJunkie
Copy link
Contributor Author

I was trying to help triaging the pull requests. If my help doesn't help, then I can stop doing it.

@UnixJunkie
Copy link
Contributor Author

And when I say it's all green, I actually went to look at some of the travis logs. Because sometimes it's green in travis but the package never installed (for example because it has too many constraints/dependencies).

@dbuenzli
Copy link
Contributor

I was trying to help triaging the pull requests. If my help doesn't help, then I can stop doing it.

I don't know but as a repository watcher I find it annoying as it generate one more notification. The maintainers do have the PR dashboard to glance over greenness so I don't think it's worth adding more notifications here.

@avsm
Copy link
Member

avsm commented Mar 15, 2016

I was trying to help triaging the pull requests. If my help doesn't help, then I can stop doing it.

I find these notifications quite useful, since Travis doesnt send a message when it successfully finishes. There's absolutely no harm in a note from a package submitter saying that they believe that a PR is ready to merge since it passes CI, especially since it sometimes takes multiple pushes to get it right.

avsm added a commit that referenced this pull request Mar 15, 2016
@avsm avsm merged commit 092b4f9 into ocaml:master Mar 15, 2016
@dbuenzli
Copy link
Contributor

I find these notifications quite useful, since Travis doesnt send a message when it successfully finishes. There's absolutely no harm in a note from a package submitter saying that they believe that a PR is ready to merge since it passes CI, especially since it sometimes takes multiple pushes to get it right.

I find this very noisy, and I'm considering removing myself from watching this repository. If we follow this pattern we get at minimum of 4 notification per package addition:

  1. The initial PR
  2. Camelus
  3. The PR person says it's all green
  4. The merge notification

wouldn't it be possible to change this so that Camelus reports directly only if it fails and otherwise once travis succeded or failed ?

@dsheets
Copy link
Member

dsheets commented Mar 15, 2016

Opened ocaml-opam/Camelus#9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants