-
Notifications
You must be signed in to change notification settings - Fork 1.2k
2 packages from huml-lang/huml-ml at 0.1.1 #28727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0c927fa to
63c2dd8
Compare
|
It is more idiomatic and recommended to release the package as huml.0.1.1, without “v”. The v becomes part of the version and is in general very error prone. Janestreet packages only use it as a workaround to their old versioning scheme. would it be possible to re-release without the “v”? |
| depends: [ | ||
| "dune" {>= "3.18"} | ||
| "ocaml" | ||
| "huml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "huml" | |
| "huml" {= version} |
to simplify dependency managements and reduce reverse dependency issues, packages from the same repository are normally released with a strict constraint on the same version. Would this be ok for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is what i want, thanks for pointing it out.
|
this makes sense to me. thanks! |
e52ab6c to
af6dcc7
Compare
af6dcc7 to
4fa4128
Compare
|
fixed. thanks @mseri also- i suspect that the CI doesn't work when the archive is built using the macos/arm version of |
4fa4128 to
6b35c54
Compare
|
Interesting and surprising, I regularly release from an arm macmini and never saw this issue (I let |
|
This looks good, thanks! |
This pull-request concerns:
huml.0.1.1: OCaml parser for the Huml markup languagehuml-cli.0.1.1: Command line interface for Huml parser🐫 Pull-request generated by opam-publish v2.6.0