Skip to content

Conversation

@nikochiko
Copy link
Contributor

@nikochiko nikochiko commented Oct 16, 2025

This pull-request concerns:

  • huml.0.1.1: OCaml parser for the Huml markup language
  • huml-cli.0.1.1: Command line interface for Huml parser


🐫 Pull-request generated by opam-publish v2.6.0

@nikochiko nikochiko force-pushed the opam-publish-huml.v0.1.1 branch 6 times, most recently from 0c927fa to 63c2dd8 Compare October 21, 2025 05:56
@mseri
Copy link
Member

mseri commented Oct 21, 2025

It is more idiomatic and recommended to release the package as huml.0.1.1, without “v”. The v becomes part of the version and is in general very error prone. Janestreet packages only use it as a workaround to their old versioning scheme.

would it be possible to re-release without the “v”?

depends: [
"dune" {>= "3.18"}
"ocaml"
"huml"
Copy link
Member

@mseri mseri Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"huml"
"huml" {= version}

to simplify dependency managements and reduce reverse dependency issues, packages from the same repository are normally released with a strict constraint on the same version. Would this be ok for you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what i want, thanks for pointing it out.

@nikochiko
Copy link
Contributor Author

this makes sense to me. thanks!

@nikochiko nikochiko force-pushed the opam-publish-huml.v0.1.1 branch 4 times, most recently from e52ab6c to af6dcc7 Compare October 21, 2025 10:04
@nikochiko nikochiko closed this Oct 21, 2025
@nikochiko nikochiko reopened this Oct 21, 2025
@nikochiko nikochiko force-pushed the opam-publish-huml.v0.1.1 branch from af6dcc7 to 4fa4128 Compare October 21, 2025 10:24
@nikochiko nikochiko changed the title 2 packages from huml-lang/huml-ml at v0.1.1 2 packages from huml-lang/huml-ml at 0.1.1 Oct 21, 2025
@nikochiko nikochiko requested a review from mseri October 21, 2025 10:28
@nikochiko
Copy link
Contributor Author

fixed. thanks @mseri

also- i suspect that the CI doesn't work when the archive is built using the macos/arm version of tar. i used the same tar command tar cvzf <name>.tar.gz --exclude='.git' --exclude='_build' --exclude='*.tar.gz' . and only the tarball from linux/x86-64 worked as expected with the CI.

@nikochiko nikochiko force-pushed the opam-publish-huml.v0.1.1 branch from 4fa4128 to 6b35c54 Compare October 21, 2025 11:37
@mseri
Copy link
Member

mseri commented Oct 21, 2025

Interesting and surprising, I regularly release from an arm macmini and never saw this issue (I let dune-release create the tarball though, not sure what command that uses)

@mseri
Copy link
Member

mseri commented Oct 21, 2025

This looks good, thanks!

@mseri mseri merged commit 74f3883 into ocaml:master Oct 21, 2025
3 of 4 checks passed
@nikochiko nikochiko deleted the opam-publish-huml.v0.1.1 branch October 21, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants