Skip to content

Conversation

@jmid
Copy link
Member

@jmid jmid commented Oct 7, 2025

This PR adds a missing conf-npm to alcotest-js.1.9.1 to avoid Program node not found in the tree or in PATH.

I can see @mseri added the same line for 1.9.0 in #27617. It would probably be good to upstream.

This was missed in #28629 and I see 72(!) occurrences of

alcotest-js.1.9.1
  tests (failed: Program node not found in the tree or in PATH)

in the still live https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/9ccf5c243215d84a1b06e9750cb040d14252b29d
from 6 days ago, so it seems like a premature merge @smorimoto 😉

I just spotted the error on #28662 where it showed up again.

@jmid
Copy link
Member Author

jmid commented Oct 8, 2025

This is down to

This should thus be good to go.

I've also upstreamed the missing test dependency here: mirage/alcotest#427.

@mseri
Copy link
Member

mseri commented Oct 8, 2025

Thanks

@mseri mseri merged commit 9348cf3 into ocaml:master Oct 8, 2025
3 of 6 checks passed
@jmid jmid deleted the alcotest-js-missing-runtest-dep branch October 8, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants