-
Notifications
You must be signed in to change notification settings - Fork 1.2k
mark conf-gmp.1 as avoid version #28540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
=== ERROR while compiling conf-gmp.1 =========================================# […] == output == + cc -c -I/usr/local/include test.c test.c: In function 'test': test.c:7:9: error: implicit declaration of function '__gmp_init'; did you mean '__gmpf_init'? [-Wimplicit-function-declaration] 7 | __gmp_init(); | ^~~~~~~~~~ | __gmpf_init
These past few days I am starting to see a number of failures caused by exploring
So it appears that something has changed, causing these to now surface and I am curious to understand what triggered it... 🤔 |
After writing the above I've created a dedicated issue for it in #28541 (as I originally intended) to help keep track. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, after having dug into the rabbit hole of #28541 I agree with this change.
This should help avoid needless CI red flags.
Hi folks, note that even after this PR, I could witness the failure in #28532 , unless I did something wrong in the rebase. |
You are right, the @raphael-proust I'm wondering what would be a good way to handle it then?
|
I don't know if/how bad is to archive conf packages. As a first attempt, I'd aim at patching the lower-bound checks to respect avoid-version tags (unless it is absurdly complicated) |
as seen in #28538