Skip to content

Conversation

@jmid
Copy link
Member

@jmid jmid commented Jul 9, 2025

The forthcoming QCheck 0.26 release in #28148 patches the float generators to avoid blind spots: c-cube/qcheck#350.
The CI run for the release however revealed such a blind spot, causing a goblint QCheck test to start failing when run with QCheck 0.26:
https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/c715a95fe87d4397d1f0658b2ae5acd528de705e

This PR therefore adds an upper bound of qcheck-core for goblint for releases 2.2.1-2.5.0, so that their tests run predictably.

I've filed an upstream PR to restore the property for the next goblint release: goblint/analyzer#1778

@sim642
Copy link
Contributor

sim642 commented Jul 9, 2025

The linked opam-CI runs also include a failure for 2.1.0: https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/c715a95fe87d4397d1f0658b2ae5acd528de705e/variant/compilers,4.14,qcheck-core.0.26,revdeps,goblint.2.1.0.
Also, versions 2.0.0 and 2.0.1 should already include the problematic test, although maybe the randomness didn't trigger its failure there?
Anyway, I would suggest adding the upper bound also to 2.0.0, 2.0.1 and 2.1.0.

@jmid
Copy link
Member Author

jmid commented Jul 9, 2025

Well spotted! I guess I missed the 2.1.0 failure because it was only on 4.14 - and not on 5.3 😬

While adding upper bounds to 2.0.0, 2.0.1, and 2.1.0 I noticed that it had no lower qcheck-core bound.
I therefore went with {>= "0.19" & < "0.26"} like the others.

Copy link
Contributor

@sim642 sim642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of the CIs fail but for unrelated reasons: some distros seem to have newer GCC which is more strict by default.

sim642 added a commit to sim642/opam-repository that referenced this pull request Jul 9, 2025
I noticed warnings the related partial application warnings in the CI for ocaml#28155.
This is the only version on opam which doesn't include the fix goblint/analyzer@4577d47.
@mseri
Copy link
Member

mseri commented Jul 10, 2025

Thanks

@mseri mseri merged commit 0367196 into ocaml:master Jul 10, 2025
0 of 2 checks passed
@jmid jmid deleted the upper-bound-qcheck-in-goblint branch July 10, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants