Fix some MDX 2.4 revdep failures #25459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With MDX 2.4 File "README.md", line 1, characters 0-0: /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/README.md _build/default/.mdx/README.md.corrected diff --git a/_build/default/README.md b/_build/default/.mdx/README.md.corrected index 6fbadb3..eda1f2d 100644 --- a/_build/default/README.md +++ b/_build/default/.mdx/README.md.corrected @@ -52,6 +52,10 @@ let cas = List.map decode_pem Ca_store.certificates in let authenticator = X509.Authenticator.chain_of_trust ~time cas in (* ... *) ``` +```mdx-error +Line 9, characters 1-3: +Error: Syntax error +``` ## Acknowledgements
Fails with:
File "README.md", line 1, characters 0-0:
/usr/bin/git --no-pager diff --no-index --color=always -u _build/default/README.md _build/default/.mdx/README.md.corrected
diff --git a/_build/default/README.md b/_build/default/.mdx/README.md.corrected
index 9f12cc7..1f9ff06 100644
--- a/_build/default/README.md
+++ b/_build/default/.mdx/README.md.corrected
@@ -1509,6 +1509,10 @@ let main ~config_changed =
)
done
```
+```mdx-error
+Line 15, characters 12-23:
+Error: Unbound value load_config
+```
Unlike the cancellation case above, where we used `Fiber.first`,
here we use `Fiber.both` to wait until we have both read the previous version of the configuration
@@ -1560,6 +1564,7 @@ It can then be used like any other Eio flow:
let r = Eio.Buf_read.of_flow zero ~max_size:100 in
traceln "Got: %S" (Eio.Buf_read.take 4 r);;
+Got: "\000\000\000\000"
+
- : unit = ()
```
|
There's a bunch more broken test cases that I saw, in |
|
Thanks |
mseri
reviewed
Mar 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating possible regressions in dune 3.4.1 I ran into some new failures that I have tracked down to be not caused by dune but rather MDX 2.4.0: #25355 so this PR fixes some of the most obvious ones.