[new release] opam-dune-lint (0.3) #24635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: - Add support for dune 3.0 , the command `dune external-lib-deps` was removed from dune. Now, the `opam-dune-lint` command works without `dune build`. (@moyodiallo ocurrent/opam-dune-lint#46).
haochenx
reviewed
Oct 18, 2023
| synopsis: "Ensure dune and opam dependencies are consistent" | ||
| description: | ||
| "opam-dune-lint checks that all ocamlfind libraries listed as dune dependencies have corresponding opam dependencies listed in the opam files. If not, it offers to add them (either to your opam files, or to your dune-project if you're generating your opam files from that)." | ||
| maintainer: ["[email protected]" "Tim McGilchrist <[email protected]>"] |
There was a problem hiding this comment.
It seems that the list of maintainers is modified. Just want to point this out and make sure it is intentional (I assume it is).
< maintainer: ["[email protected]"]
---
> maintainer: ["[email protected]" "Tim McGilchrist <[email protected]>"]There was a problem hiding this comment.
Yes it is.
cc: @tmcgilchrist
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure dune and opam dependencies are consistent
CHANGES:
dune external-lib-depswas removed fromdune. Now, the
opam-dune-lintcommand works withoutdune build. (@moyodiallo Fix for "dune external-lib-deps" command ocurrent/opam-dune-lint#46).