Skip to content

Conversation

@hannesm
Copy link
Member

@hannesm hannesm commented Mar 9, 2023

Simple symmetric cryptography for the modern age

CHANGES:

…age, mirage-crypto-rng-lwt, mirage-crypto-rng-eio, mirage-crypto-rng-async, mirage-crypto-pk and mirage-crypto-ec (0.11.1)

CHANGES:

* BUGFIX Chacha20 decrypt and encrypt with empty data (previously lead to
  segmentation fault, reported by @smondet in mirage/mirage-crypto#172, fix in mirage/mirage-crypto#173 by @reynir
  @hannesm), added tests with empty data for all symmetric ciphers
@hannesm
Copy link
Member Author

hannesm commented Mar 9, 2023

FWIW (opam-repo-ci people), I'm a bit curious why "mirage-crypto-pk" revdeps run returns the empty set, while https://opam.ocaml.org/packages/mirage-crypto-pk/ lists quite some reverse dependencies thereof.

I am not worried since the revdeps of mirage-crypto cover these packages -- I'm just curious and maybe you're interested in this divergence.

EDIT: Furthermore, it's a bit strange that e.g. tls and x509 do not show up in the revdeps at all. Any idea what is causing that?

@kit-ty-kate
Copy link
Member

Thanks for noticing this... it's seems to be caused by @MisterDA's change in the docker images in ocurrent/ocaml-dockerfile#147

opam@32f7b123968f:~$ opam list -s --color=never --depends-on 'mirage-crypto-pk.0.11.1' --coinstallable-with 'mirage-crypto-pk.0.11.1' --installable --all-versions --recursive --depopts
opam@32f7b123968f:~$ opam install webmachine.0.5.0 mirage-crypto-pk.0.11.1
[ERROR] Package conflict!
  * Missing dependency:
    - conf-gmp
    depends on the unavailable system package 'libgmp-dev'. Use `--no-depexts' to attempt installation anyway, or it is possible that a depext package name in the opam file is incorrect.

No solution found, exiting
opam@32f7b123968f:~$ sudo apt-get install libgmp-dev
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package libgmp-dev
opam@32f7b123968f:~$ sudo apt-get update
Get:1 http://deb.debian.org/debian bullseye InRelease [116 kB]
Get:2 http://deb.debian.org/debian-security bullseye-security InRelease [48.4 kB]
Get:3 http://deb.debian.org/debian bullseye-updates InRelease [44.1 kB]
Get:4 http://deb.debian.org/debian bullseye/main arm64 Packages [8072 kB]
Get:5 http://deb.debian.org/debian-security bullseye-security/main arm64 Packages [230 kB]
Get:6 http://deb.debian.org/debian bullseye-updates/main arm64 Packages [12.0 kB]
Fetched 8522 kB in 2s (4629 kB/s)                         
Reading package lists... Done
opam@32f7b123968f:~$ opam install webmachine.0.5.0 mirage-crypto-pk.0.11.1
The following actions will be performed:
=== install 43 packages
  - install angstrom            0.15.0       [required by uri]
 [...]

I'll get that reverted and fixed right away.

kit-ty-kate added a commit to ocurrent/opam-repo-ci that referenced this pull request Mar 9, 2023
@hannesm
Copy link
Member Author

hannesm commented Mar 9, 2023

CI looks fine to me - failures are unrelated.

@hannesm
Copy link
Member Author

hannesm commented Mar 14, 2023

Is there anything I can do to drive this PR to completion (and getting it merged)?

@kit-ty-kate
Copy link
Member

Thanks. Sorry for the wait

@kit-ty-kate kit-ty-kate merged commit 0209e8b into ocaml:master Mar 14, 2023
kit-ty-kate added a commit to ocurrent/opam-repo-ci that referenced this pull request Apr 14, 2023
kit-ty-kate added a commit to ocurrent/opam-repo-ci that referenced this pull request Apr 14, 2023
tmcgilchrist pushed a commit to ocurrent/opam-repo-ci that referenced this pull request May 16, 2023
@hannesm hannesm deleted the release-mirage-crypto-v0.11.1 branch February 27, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants