Skip to content

Package ocsigenserver.3.0.0#18717

Merged
kit-ty-kate merged 6 commits into
ocaml:masterfrom
jrochel:opam-publish-ocsigenserver.3.0.0
Jun 30, 2021
Merged

Package ocsigenserver.3.0.0#18717
kit-ty-kate merged 6 commits into
ocaml:masterfrom
jrochel:opam-publish-ocsigenserver.3.0.0

Conversation

@jrochel
Copy link
Copy Markdown
Contributor

@jrochel jrochel commented May 21, 2021

See also the previous incarnation of this PR : #18577

@jrochel jrochel force-pushed the opam-publish-ocsigenserver.3.0.0 branch 2 times, most recently from 017aceb to 9acefce Compare May 21, 2021 08:44
@jrochel jrochel force-pushed the opam-publish-ocsigenserver.3.0.0 branch from 5004f3c to 427a470 Compare June 11, 2021 16:02
@jrochel
Copy link
Copy Markdown
Contributor Author

jrochel commented Jun 30, 2021

@kit-ty-kate Hi there. Is there something I should do about this PR, maybe reduce its footprint? I feel that I cannot do anything about the various compilation errors. There reasons are either problems in other packages, operating systems, etc.

@kit-ty-kate
Copy link
Copy Markdown
Member

Hi, sorry, there was still some failures in ocsigenserver itself:

# File "ocsigen_cohttp.ml", line 299, characters 5-16:
# 299 |     ~tls_own_key () >>= fun conduit_ctx ->
#            ^^^^^^^^^^^
# Error: The function applied to this argument has type
#          ?tls_server_key:Conduit_lwt_unix.tls_server_key ->
#          Conduit_lwt_unix.ctx Lwt.t
# This argument cannot be applied with label ~tls_own_key
# make[2]: *** [Makefile:61: ocsigen_cohttp.cmo] Error 2
# make[2]: Leaving directory '/home/opam/.opam/4.11/.opam-switch/build/ocsigenserver.3.0.0/src/server'
# make[1]: *** [Makefile:6: all] Error 2
# make[1]: Leaving directory '/home/opam/.opam/4.11/.opam-switch/build/ocsigenserver.3.0.0/src'
# make: *** [Makefile:8: all] Error 2

I'll try my best to fix everything, if there are more, by tonight.

@kit-ty-kate kit-ty-kate merged commit edb94fd into ocaml:master Jun 30, 2021
@kit-ty-kate
Copy link
Copy Markdown
Member

Thanks! I'm really sorry for the very long delay. That a combination of forgetting about it, getting discouraged at reading logs I'm not familiar with, getting distracted and being busy with other things.

Could you return the fix in the opam file upstream?

@jrochel
Copy link
Copy Markdown
Contributor Author

jrochel commented Jul 1, 2021

Thanks a lot! I completely understand the long delay. I have applied the fix upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants