Skip to content

mark conduit*3 as unavailable#18502

Closed
hannesm wants to merge 1 commit into
ocaml:masterfrom
hannesm:no-conduit3
Closed

mark conduit*3 as unavailable#18502
hannesm wants to merge 1 commit into
ocaml:masterfrom
hannesm:no-conduit3

Conversation

@hannesm
Copy link
Copy Markdown
Member

@hannesm hannesm commented Apr 14, 2021

I think this is what we concluded -- that conduit 3 should be avoided (and will be revised in the future)

//cc @avsm @samoht @dinosaure

@dinosaure
Copy link
Copy Markdown
Contributor

Agree with this where it seems that nobody really use conduit.3.0.0. As cohttp.3.0.0, the best is to remove and release conduit.4.0.0 may be, I'm not really sure.

@avsm
Copy link
Copy Markdown
Member

avsm commented Apr 14, 2021

I'm generally reluctant to remove releases from opam-repository without an exceptional reason, as you dont know which downstream repositories are using this package. @samoht @hannesm would you consider releasing a conduit.4.0.0 that is the same as the conduit.2.x series so it can continue forwards from a versioning perspective? A note similar to the one in cohttp's CHANGES file that @mseri did would suffice to explain the reasoning.

@hannesm
Copy link
Copy Markdown
Member Author

hannesm commented Apr 14, 2021

would you consider releasing a conduit.4.0.0 that is the same as the conduit.2.x series so it can continue forwards from a versioning perspective?

This is a great idea, we should do that. I can work on that with changes for tls 0.13 and dns 5.0 (IPv6) included.

@camelus
Copy link
Copy Markdown
Contributor

camelus commented Apr 14, 2021

Commit: e428508

A pull request by opam-seasoned @hannesm.

☀️ All lint checks passed e428508
  • These packages passed lint tests: conduit-async-ssl.3.0.0, conduit-async-tls.3.0.0, conduit-async.3.0.0, conduit-lwt-ssl.3.0.0, conduit-lwt-tls.3.0.0, conduit-lwt.3.0.0, conduit-mirage.3.0.0, conduit-tls.3.0.0, conduit.3.0.0

🌤️ Installability check (-9)
  • these releases are not installable anymore (9): conduit.3.0.0 conduit-async.3.0.0 conduit-async-ssl.3.0.0 conduit-async-tls.3.0.0 conduit-lwt.3.0.0 conduit-lwt-ssl.3.0.0 conduit-lwt-tls.3.0.0 conduit-mirage.3.0.0 conduit-tls.3.0.0

@avsm
Copy link
Copy Markdown
Member

avsm commented Apr 14, 2021

Many thanks @hannesm! I'll close this PR for now then.

@avsm avsm closed this Apr 14, 2021
@hannesm
Copy link
Copy Markdown
Member Author

hannesm commented Apr 14, 2021

I don't understand why closing this PR is a way forward. There is CI trouble with conduit*3, and it looks like nobody has interest to support & develop conduit 3. Why should it stay as available in opam-repository?

@mseri
Copy link
Copy Markdown
Member

mseri commented Apr 15, 2021

I agree with @hannesm, we should probably mark it unavailable sooner rather than later, then push to have conduit 4.0 out immediately. Otherwise, we risk that people start updating their code or using the new library which will be de-facto unmaintained.

@hannesm hannesm deleted the no-conduit3 branch July 26, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants