Closed
Conversation
CHANGES: - Driver (important for bucklescript): handling binary AST's, accept any supported version as input; preserve that version (ocaml-ppx/ppxlib#205, @pitag-ha) - `-as-ppx`: take into account the `-loc-filename` argument (ocaml-ppx/ppxlib#197, @pitag-ha) - Add input name to expansion context (ocaml-ppx/ppxlib#202, @pitag-ha) - Add Driver.V2: give access to expansion context in whole file transformation callbacks of `register_transformation` (ocaml-ppx/ppxlib#202, @pitag-ha) - Driver: take `-cookie` argument into account, also when the input is a binary AST (@pitag-ha, ocaml-ppx/ppxlib#209) - `run_as_ppx_rewriter`: take into account the arguments `-loc-filename`, `apply` and `dont-apply` (ocaml-ppx/ppxlib#205, @pitag-ha) - Location.Error: add functions `raise` and `update_loc` (ocaml-ppx/ppxlib#205, @pitag-ha)
Contributor
Author
|
Hmm did we break something? That's not intentional, let me look into it! |
Contributor
Author
|
If you don't mind, I'll force push to erase your commit so we can look into the revdeps failure! |
NathanReb
force-pushed
the
release-ppxlib-0.21.0
branch
from
0101d63 to
a5645e5
Compare
Contributor
|
Commit: a5645e5 A pull request by opam-seasoned @NathanReb. ☀️ All lint checks passed a5645e5
☀️ Installability check (+1)
|
Contributor
Author
|
It indeed turned out to be an error on our part, I'll fix it and re-release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard library for ppx rewriters
CHANGES:
Driver (important for bucklescript): handling binary AST's, accept any
supported version as input; preserve that version (Add bucklescript support ocaml-ppx/ppxlib#205, @pitag-ha)
-as-ppx: take into account the-loc-filenameargument (Re-implement standalone_run_as_ppx_rewriter ocaml-ppx/ppxlib#197, @pitag-ha)Add input name to expansion context (Make context available in transformation callbacks ocaml-ppx/ppxlib#202, @pitag-ha)
Add Driver.V2: give access to expansion context in whole file transformation
callbacks of
register_transformation(Make context available in transformation callbacks ocaml-ppx/ppxlib#202, @pitag-ha)Driver: take
-cookieargument into account, also when the input is abinary AST (@pitag-ha, Fix cli cookies handling ocaml-ppx/ppxlib#209)
run_as_ppx_rewriter: take into account the arguments-loc-filename,applyanddont-apply(Add bucklescript support ocaml-ppx/ppxlib#205, @pitag-ha)Location.Error: add functions
raiseandupdate_loc(Add bucklescript support ocaml-ppx/ppxlib#205, @pitag-ha)