Skip to content

[new release] cohttp-lwt-jsoo, cohttp, cohttp-lwt, cohttp-lwt-unix, cohttp-top, cohttp-async and cohttp-mirage (2.2.0)#14562

Merged
kit-ty-kate merged 3 commits into
ocaml:masterfrom
avsm:release-cohttp-2.2.0
Jul 24, 2019
Merged

[new release] cohttp-lwt-jsoo, cohttp, cohttp-lwt, cohttp-lwt-unix, cohttp-top, cohttp-async and cohttp-mirage (2.2.0)#14562
kit-ty-kate merged 3 commits into
ocaml:masterfrom
avsm:release-cohttp-2.2.0

Conversation

@avsm
Copy link
Copy Markdown
Member

@avsm avsm commented Jul 20, 2019

CoHTTP implementation for the Js_of_ocaml JavaScript compiler

CHANGES:
  • Previously if the client closed the connection while cohttp was
    handling a request, the server would crash (by default, unless the
    user overrode that using on_exn or changing Lwt's async exception
    handler). Now, cohttp will just log this at info level and
    continue. Exceptions produced by user code are logged as errors,
    while other exceptions generated by cohttp call back to the conduit
    exception handler, as before. (Better handling of IO errors mirage/ocaml-cohttp#669 @talex5)

avsm added 2 commits July 20, 2019 21:51
…ohttp-top, cohttp-async and cohttp-mirage (2.2.0)

CHANGES:

- Previously if the client closed the connection while cohttp was
  handling a request, the server would crash (by default, unless the
  user overrode that using `on_exn` or changing Lwt's async exception
  handler). Now, cohttp will just log this at `info` level and
  continue. Exceptions produced by user code are logged as errors,
  while other exceptions generated by cohttp call back to the conduit
  exception handler, as before. (mirage/ocaml-cohttp#669 @talex5)
@camelus
Copy link
Copy Markdown
Contributor

camelus commented Jul 20, 2019

☀️ All lint checks passed cf1985f
  • These packages passed lint tests: cohttp-async.2.2.0, cohttp-lwt-jsoo.2.2.0, cohttp-lwt-unix.2.0.0, cohttp-lwt-unix.2.1.3, cohttp-lwt-unix.2.2.0, cohttp-lwt.2.2.0, cohttp-mirage.2.1.0, cohttp-mirage.2.1.1, cohttp-mirage.2.1.3, cohttp-mirage.2.2.0, cohttp-top.2.2.0, cohttp.2.2.0

☀️ Installability check (+7)
  • new installable packages (7): cohttp.2.2.0 cohttp-async.2.2.0 cohttp-lwt.2.2.0 cohttp-lwt-jsoo.2.2.0 cohttp-lwt-unix.2.2.0 cohttp-mirage.2.2.0 cohttp-top.2.2.0

@kit-ty-kate
Copy link
Copy Markdown
Member

Older versions of the Cohttp packages need updated constraints

@kit-ty-kate
Copy link
Copy Markdown
Member

kit-ty-kate commented Jul 23, 2019

In my opinion it's a bit of a sloppy fix but it's a fix nonetheless. Something tells me it would be slightly better if every cohttp packages had a fixed constraint "cohttp" {= version} but not all packages have a matching version, also I was not sure if people were actually using different version of cohttp with subpackages of totally different versions, it allows more combinations but it's also more tedious to maintain

@kit-ty-kate
Copy link
Copy Markdown
Member

Should be alright now. Thanks!

@kit-ty-kate kit-ty-kate merged commit 6c4dd8e into ocaml:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants