[new release] cohttp-lwt-jsoo, cohttp, cohttp-lwt, cohttp-lwt-unix, cohttp-top, cohttp-async and cohttp-mirage (2.2.0)#14562
Merged
Conversation
…ohttp-top, cohttp-async and cohttp-mirage (2.2.0) CHANGES: - Previously if the client closed the connection while cohttp was handling a request, the server would crash (by default, unless the user overrode that using `on_exn` or changing Lwt's async exception handler). Now, cohttp will just log this at `info` level and continue. Exceptions produced by user code are logged as errors, while other exceptions generated by cohttp call back to the conduit exception handler, as before. (mirage/ocaml-cohttp#669 @talex5)
Contributor
☀️ All lint checks passed cf1985f
☀️ Installability check (+7)
|
Member
|
Older versions of the Cohttp packages need updated constraints |
Member
|
In my opinion it's a bit of a sloppy fix but it's a fix nonetheless. Something tells me it would be slightly better if every cohttp packages had a fixed constraint |
Member
|
Should be alright now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoHTTP implementation for the Js_of_ocaml JavaScript compiler
CHANGES:
handling a request, the server would crash (by default, unless the
user overrode that using
on_exnor changing Lwt's async exceptionhandler). Now, cohttp will just log this at
infolevel andcontinue. Exceptions produced by user code are logged as errors,
while other exceptions generated by cohttp call back to the conduit
exception handler, as before. (Better handling of IO errors mirage/ocaml-cohttp#669 @talex5)