[new release] cohttp-async and cohttp-mirage (2.1.1)#13826
Merged
Conversation
…ohttp-top, cohttp-async and cohttp-mirage (2.1.1) CHANGES: - `cohttp-mirage`: remove dependency on the `result` module (mirage/ocaml-cohttp#662 @hannesm) - Support Async v0.12.0 and higher (mirage/ocaml-cohttp#661 @copy)
Member
|
@avsm ionly cohttp-mirage and cohttp-async changed, should we limit the release to only those two? |
Member
Author
|
@mseri -- i'm going with the convention of releasing everything for convenience for now. It makes the constraints so much easier to manage and ensures versions don't get out sync. I agree we should improve dune-release to make the single-package case easier though! |
Member
Author
|
I could rm the extra packages here from this branch though... |
Member
|
I used to skip versdion numbers to make sure releases were always incremental but avoiding forcing rebuilds. In principle I am fine with either choice, I just wanted to double check. |
Member
Author
|
ive pushed a changeset to remove the unchanged packages and tighten constraints |
avsm
changed the title
Member
|
Thanks |
Contributor
☀️ All lint checks passed 2d486c8
☀️ Installability check (10943 → 10945)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoHTTP implementation for the Js_of_ocaml JavaScript compiler
CHANGES:
cohttp-mirage: remove dependency on theresultmodule(cohttp-mirage: remove result, requires 4.05.0 anyways mirage/ocaml-cohttp#662 @hannesm)