[new release] cohttp-lwt-jsoo, cohttp, cohttp-lwt, cohttp-lwt-unix, cohttp-top, cohttp-async and cohttp-mirage (2.0.0)

[avsm]

CoHTTP implementation for the Js_of_ocaml JavaScript compiler

• Project page: https://github.com/mirage/ocaml-cohttp
• Documentation: https://mirage.github.io/ocaml-cohttp/

CHANGES:

Compatibility breaking interface changes:

Async: Expert response action no longer writes empty HTTP body (mirage/ocaml-cohttp#647 by @andreas)

In cohttp.0.99, a number of subpackages were turned into explicit
opam packages to simplify dependency management.
To aid migration, some compatability shims were left in place so that
the old findlib names would continue to work. They have now been removed
as of this release. If you were still using them, then please rename
them as follows in your dune or ocamlbuild files:

• cohttp.lwt-core -> cohttp-lwt
• cohttp.lwt -> cohttp-lwt-unix
• cohttp.js -> cohttp-lwt-jsoo
• cohttp.async -> cohttp-async
• cohttp.top -> cohttp-top

Other changes and bugfixes:

• Lwt, Mirage: Add log warnings for uncaught exceptions (Add log warnings for uncaught exceptions mirage/ocaml-cohttp#592 by @ansiwen)
• Log invalid client input and do not catch out of memory exceptions (log invalid client input and do not catch out of memory mirage/ocaml-cohttp#652 @hannesm)
• Port opam files to opam2 and add local synopsis and descriptions.
• Lwt: Add Expert response action for servers (Add expert mode for cohttp-lwt mirage/ocaml-cohttp#647 by @andreas)
• Use the namespaced js_of_ocaml interfaces from 3.3.0 onwards (use namespaced jsoo interfaces mirage/ocaml-cohttp#654 @avsm)
• Use Base64 3.1.0 interfaces (use base64-3.1.0 interface and remove some opam file redundancy mirage/ocaml-cohttp#655 @avsm)
• Clean up redundant conflicts in the opam files (@avsm)

[avsm]

Let's take a careful look at the revdep breakage before merging this. The cstruct fallout was more than I expected in #13372 :-)

[camelus]

☀️ All lint checks passed 7a73e02

• These packages passed lint tests: cohttp-async.2.0.0, cohttp-lwt-jsoo.2.0.0, cohttp-lwt-unix.2.0.0, cohttp-lwt.2.0.0, cohttp-mirage.2.0.0, cohttp-top.2.0.0, cohttp.2.0.0

---

☀️ Installability check (10392 → 10399)

• new installable packages (7): cohttp.2.0.0 cohttp-async.2.0.0 cohttp-lwt.2.0.0 cohttp-lwt-jsoo.2.0.0
cohttp-lwt-unix.2.0.0 cohttp-mirage.2.0.0 cohttp-top.2.0.0

[mseri]

Before I look at the revdeps, is this osx travis failure something already seen?

+ /Users/travis/.opam/opam-init/hooks/sandbox.sh "build" "dune" "runtest" "-p" "cohttp-async" "-j" "1" (CWD=/Users/travis/.opam/ocaml-system/.opam-switch/build/cohttp-async.2.0.0)
- test_async_integration alias cohttp-async/test/runtest (exit 1)
- (cd _build/default/cohttp-async/test && ./test_async_integration.exe)
- (((pid 74383) (thread_id 0)) "2019-02-04 14:16:11.472992Z"
-  "unhandled exception in Async scheduler"
-  ("unhandled exception"
-   ((monitor.ml.Error
-     (Unix.Unix_error "Operation not permitted" bind
-      "((fd 3) (addr (ADDR_INET 0.0.0.0 9193)))")
-     ("Raised at file \"src/core_unix.ml\", line 50, characters 4-43"
-      "Called from file \"src/syscall.ml\", line 19, characters 12-16"
-      "Re-raised at file \"src/fd.ml\", line 262, characters 18-27"
-      "Called from file \"src/deferred1.ml\", line 20, characters 40-45"
-      "Called from file \"src/job_queue.ml\", line 159, characters 6-47"
-      "Caught by monitor Tcp.close_sock_on_error"))
-    ((pid 74383) (thread_id 1)))))
[ERROR] The compilation of cohttp-async failed at
        "/Users/travis/.opam/opam-init/hooks/sandbox.sh build dune runtest -p
        cohttp-async -j 1".

Just lack of root permits?

[avsm]

Yeah that error is due to opam2 sandboxing preventing network access during the tests running. We should probably fix that in the test suite to not fail hard if sandboxed

[avsm]

need to wait for #13391 and #13392 to be merged and then re-merge this with master to see if anything else breaks

[avsm]

dependent PR merged, so re-testing against master

[mseri]

Impressive! All green with the exception of the osx issue discussed above

[mseri]

Thanks

[avsm]

Now the real fallout can be found :-)