[new release] cohttp, cohttp-lwt-unix, cohttp-async, cohttp-mirage, cohttp-lwt-jsoo, cohttp-lwt and cohttp-top (1.2.0)

[mseri]

An OCaml library for HTTP clients and servers

• Project page: https://github.com/mirage/ocaml-cohttp
• Documentation: https://mirage.github.io/ocaml-cohttp/

CHANGES:

• Support more than a single chunk extension for RFC7320 compliance (A chunk can have more than one chunk extension mirage/ocaml-cohttp#618 by @djs55)
• Lwt-unix: add a ?backlog argument to the serve function (@samoht)
• Use the uri.2.0.0 interfaces for sexpression generation of types (@avsm)
• Switch to sexplib0 for a more lightweight s-expression library (@mseri)
• Minimum OCaml compiler version requirement is now 4.04.1 (@mseri)
• Add an example of using custom resolvers to the README (@mseri)

[kit-ty-kate]

Some of the tests fail:

#=== ERROR while compiling cohttp-lwt-unix.1.2.0 ==============================#
# context     2.0.0 | linux/x86_64 | ocaml-base-compiler.4.07.0 | file:///home/travis/build/ocaml/opam-repository
# path        ~/.opam/4.07.0/.opam-switch/build/cohttp-lwt-unix.1.2.0
# command     ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p cohttp-lwt-unix -j 1
# exit-code   1
# env-file    ~/.opam/log/cohttp-lwt-unix-32396-a00279.env
# output-file ~/.opam/log/cohttp-lwt-unix-32396-a00279.out
### output ###
# [...]
# Request 2
# 
# Running massive chunked
# Running unreadable file returns 500
# Error handling ((headers
#   ((host 0.0.0.0:9193) (transfer-encoding chunked)
#    (user-agent ocaml-cohttp/1.2.0)))
#  (meth POST) (resource /) (version HTTP_1_1) (encoding Chunked)): Unix.Unix_error(Unix.EACCES, "open", "unreadable500")
# Running no leaks on requests
# ........
# Ran: 8 tests in: 0.00 seconds.
# OK

[mseri]

That should not be a failure. The error is printed due to the active debug output but the body and status are correctly

Status: 500 Internal Server Error
Body: Error: Internal Server Error

and in fact ounit is exiting with an OK at the end of the tests. I don't understand why it is marked at failed by opam

[mseri]

Oh, no, the failure is above:

- .......FF.
- ==============================================================================
- Failure: Parser:8:mutate_simple_req
- 
- not equal
- differences: Expected:
- POST /foo/bar HTTP/1.1
- foo: bar
- host: localhost
- transfer-encoding: chunked
- user-agent: ocaml-cohttp/
- 
- 6
- foobar
- 0
- 
- Result:
- POST /foo/bar HTTP/1.1
- foo: bar
- host: localhost
- transfer-encoding: chunked
- user-agent: ocaml-cohttp/1.2.0
- 
- 6
- foobar
- 0
- 
- 
- ------------------------------------------------------------------------------
- ==============================================================================
- Failure: Parser:7:make_simple_req
- 
- not equal
- differences: Expected:
- POST /foo/bar HTTP/1.1
- foo: bar
- host: localhost
- transfer-encoding: chunked
- user-agent: ocaml-cohttp/
- 
- 6
- foobar
- 0
- 
- Result:
- POST /foo/bar HTTP/1.1
- foo: bar
- host: localhost
- transfer-encoding: chunked
- user-agent: ocaml-cohttp/1.2.0
- 
- 6
- foobar
- 0
- 
- 
- ------------------------------------------------------------------------------
- Ran: 10 tests in: 0.00 seconds.
- FAILED: Cases: 10 Tried: 10 Errors: 0 Failures: 2 Skip:  0 Todo: 0 Timeouts: 0.

[mseri]

I need to try and reproduce it locally. On our Travis and my desktop it is passing those tests, but it looks like it has something to do with the version in the user-agent

[camelus]

☀️ All lint checks passed 6dd63ed

• These packages passed lint tests: cohttp-async.1.2.0, cohttp-lwt-jsoo.1.2.0, cohttp-lwt-unix.1.2.0, cohttp-lwt.1.2.0, cohttp-mirage.1.2.0, cohttp-top.1.2.0, cohttp.1.2.0

---

☀️ Installability check (9825 → 9832)

• new installable packages (7): cohttp.1.2.0 cohttp-async.1.2.0 cohttp-lwt.1.2.0 cohttp-lwt-jsoo.1.2.0 cohttp-lwt-unix.1.2.0
cohttp-mirage.1.2.0 cohttp-top.1.2.0

[mseri]

There was a partially incorrect test, it should have already failed in the last two releases, weird. It should be fixed now

[mseri]

Those tests are fixed. Cohttp-async is failing on osx, the library did not really change, only some dependencies bounds did, I will see if I can do something about it, it may have to do with the sandbox

[mseri]

The osx failure is due to the restrictions of the sandbox on osx. I don’t see an easy fix, I could disable the tests on osx, or we can simply ignore it for the moment

[kit-ty-kate]

looks ok now. Thanks!

[mseri]

Thanks!