[new release] conduit-lwt-unix and conduit-async (v1.2.0)#12552
Conversation
✅ All lint checks passed ed646c8
✅ Installability check (9302 → 9304)
|
| depends: [ | ||
| "jbuilder" {build & >="1.0+beta9"} | ||
| "core" | ||
| "ppx_sexp_conv" |
There was a problem hiding this comment.
Oh yes, you are right. I got confused because it is a build dependency below.
| "jbuilder" {build & >="1.0+beta9"} | ||
| "core" | ||
| "ppx_sexp_conv" | ||
| "sexplib" |
There was a problem hiding this comment.
Is this always needed or is it tied to ppx_sexp_conv and its need depends on the version of ppx_sexp_conv?
There was a problem hiding this comment.
it's used in the code (with Sexplib.Sexp.to_string)
| depends: [ | ||
| "base-unix" | ||
| "jbuilder" {build & >="1.0+beta9"} | ||
| "ppx_sexp_conv" {build} |
There was a problem hiding this comment.
Should this be a standard dependency?
|
I've also fixed the |
|
The Alpine CI failure is expected, do you know if the cohttp-async.1.0.0 revdep failure is expected (logs here https://ci.ocamllabs.io/log/saved/docker-run-026b5dd972e49be5e0434d394c6eb2bb/c6ecac68a4ebdc9a7a3350a57e1e482b003e7546)? |
|
No idea, but it seems that |
|
All the fixes have been merged. I think we can merge, but I would be great if we let the CI run again. What if we rebase the PR? |
CHANGES: * Correct depopt for conduit-lwt-unix (mirage/ocaml-conduit#260, @dra27) * async: provide all `Async_ssl` options at config (mirage/ocaml-conduit#263, @vbmithr) * async: add a V2 module for a new versioned API (mirage/ocaml-conduit#265, @rgrinberg) * lwt-unix: do not link with tls.lwt on windows (mirage/ocaml-conduit#267, @samoht)
samoht
force-pushed
the
release-conduit-async-v1.2.0
branch
from
e40caa0 to
ed646c8
Compare
|
Rebased |
|
Thanks, now the CI is all green (with exception of the expected Alpine failure) |
4 participants
CHANGES:
Async_ssloptions at config (Async: provide allAsync_ssloptions at config mirage/ocaml-conduit#263, @vbmithr)