Update lower bounds and fix tests on < 4.10 and macos #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The third commit removes an unstable output, again found by opam-ci. |
Julow
changed the title
Collaborator
Author
|
The fourth commit fixes the way the tests are run by Opam for |
This test fails due to linker warnings on some versions of macos but also with newer versions of Dune where the output HTML is stored in different location. This test is too hard to maintain and is probably covered by Dune's own tests.
The previous rule was attempting to run odoc's test when building odoc-parser only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was found by Opam's CI.
For an unknown reason, it was not caught by https://github.com/ocaml/odoc/actions/runs/7180162543/job/19551836931