Skip to content

Remove odoc_html_support_files.ml #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julow merged 3 commits into from
Dec 6, 2023
Merged

Remove odoc_html_support_files.ml #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d34ae0
Remove odoc_html_support_files.ml
EmileTrotignon Nov 24, 2023
72a57ea
add crunch to deps
EmileTrotignon Dec 6, 2023
d3a16bd
add crunch dep to bench
EmileTrotignon Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions odoc-bench.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,5 @@ depends: [
"mdx" {>= "2.3.0"}
"core" {= "v0.16.2"}
"core_kernel" {= "v0.16.0"}
"crunch"
]
2 changes: 1 addition & 1 deletion odoc.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ depends: [

"ppx_expect" {with-test}
"bos" {with-test}
"crunch" {with-test}
"crunch"

("ocaml" {< "4.07.0" & with-test} | "bisect_ppx" {with-test & > "2.5.0"})
]
Expand Down
42 changes: 20 additions & 22 deletions src/html_support_files/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,34 +5,32 @@
(aliases runtest support-files)
(enabled_if
(> %{ocaml_version} 4.08))
(target odoc_html_support_files.ml)
Copy link
Collaborator

@Julow Julow Nov 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odoc.opam is not uptodate as crunch is still listed with-test. It would be nice to test various versions of crunch and find an eventual lower bound.

(deps
(:x odoc_html_support_files.ml)
(glob_files *.js)
(glob_files *.css)
(glob_files_rec *.ttf)
(glob_files_rec *.woff2))
(action
(progn
(setenv
SOURCE_DATE_EPOCH
0
(run
ocaml-crunch
.
-e
js
-e
css
-e
ttf
-e
woff2
-o
%{x}.corrected
-m
plain
-s))
(diff? %{x} %{x}.corrected))))
(setenv
SOURCE_DATE_EPOCH
0
(run
ocaml-crunch
.
-e
js
-e
css
-e
ttf
-e
woff2
-o
odoc_html_support_files.ml
-m
plain
-s))))

(library
(name odoc_html_support_files)
Expand Down
Loading