make the github links on ocaml.org point to the ocaml org #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than just the ocaml repository (closes ocaml#2043).
cuihtlauac
approved these changes
Feb 12, 2024
Collaborator
cuihtlauac
left a comment
cuihtlauac
left a comment
There was a problem hiding this comment.
That looks good to me, thanks @The-Amoghavarsha.
We should merge this. However, it looks as a minimum/interim solution. I believe we need more:
- Text, not mere links
- Links to
- The OCaml GitHub organisation: https://github.com/ocaml
- The OCaml compiler: https://github.com/ocaml/ocaml
- The ocaml.org project:
- The Ocaml Foundation: https://ocaml-sf.org/
Some need to go into Community, some in Platform and some in each page's footer.
sabine
approved these changes
Feb 12, 2024
Collaborator
sabine
left a comment
sabine
left a comment
There was a problem hiding this comment.
Good interim solution because the org page on GitHub is actually really nice because the main repos are pinned. Let's merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than just the ocaml repository (closes #2043).