-
Notifications
You must be signed in to change notification settings - Fork 367
changelog: infer date from slug if not in metadata #1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For dune I checked that the metadata was consistently duplicated (there was one discrepancy but the slug version was correct). |
The date is present in 2 places: in the slug and in the yaml metadata. This is redundant and creates extra work for contributors. This makes the yaml metadata optional; in that case the date is inferred from the slug.
c1f746b to
321d8ba
Compare
|
Here are the discrepancies I'm finding on the whole set: I'm tempted to keep the slug date everywhere. |
|
OK let's do this |
|
Done. I had to sanitize a bit the input when parsing because some slugs look like |
cuihtlauac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. In 1984, we rewrite history to remove redundancy. I like that.
|
it's ok to change the slugs as well, but this will break some links so that's more risky. up to you! |
|
Consistency primes accuracy, let's leave the slugs unchanged. |
The date is present in 2 places: in the slug and in the yaml metadata.
This is redundant and creates extra work for contributors.
This makes the yaml metadata optional; in that case the date is inferred from the slug.