Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract modules from Install_rules #7590

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
File renamed without changes.

Large diffs are not rendered by default.

448 changes: 448 additions & 0 deletions src/dune_rules/install/stanzas_to_entries.ml

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions src/dune_rules/install/stanzas_to_entries.mli
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
val stanzas_to_entries :
Super_context.t -> Install.Entry.Sourced.t list Package.Name.Map.t Memo.t
33 changes: 33 additions & 0 deletions src/dune_rules/package_paths.ml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
open Import

let opam_file (ctx : Context.t) (pkg : Package.t) =
let opam_file = Package.opam_file pkg in
let exists =
match pkg.has_opam_file with
| Exists b -> b
| Generated -> true
in
if exists then Some (Path.Build.append_source ctx.build_dir opam_file)
else None

let meta_file (ctx : Context.t) pkg =
Path.Build.append_source ctx.build_dir (Package.meta_file pkg)

let deprecated_meta_file (ctx : Context.t) pkg name =
Path.Build.append_source ctx.build_dir (Package.deprecated_meta_file pkg name)

let build_dir (ctx : Context.t) (pkg : Package.t) =
let dir = Package.dir pkg in
Path.Build.append_source ctx.build_dir dir

let dune_package_file ctx pkg =
let name = Package.name pkg in
Path.Build.relative (build_dir ctx pkg)
(Package.Name.to_string name ^ ".dune-package")

let deprecated_dune_package_file ctx pkg name =
Path.Build.relative (build_dir ctx pkg)
(Package.Name.to_string name ^ ".dune-package")

let meta_template ctx pkg =
Path.Build.extend_basename (meta_file ctx pkg) ~suffix:".template"
17 changes: 17 additions & 0 deletions src/dune_rules/package_paths.mli
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
open Import

val opam_file : Context.t -> Package.t -> Path.Build.t option

val deprecated_meta_file :
Context.t -> Package.t -> Package.Name.t -> Path.Build.t

val dune_package_file : Context.t -> Package.t -> Path.Build.t

val meta_file : Context.t -> Package.t -> Path.Build.t

val meta_template : Context.t -> Package.t -> Path.Build.t

val deprecated_dune_package_file :
Context.t -> Package.t -> Package.Name.t -> Path.Build.t

val build_dir : Context.t -> Package.t -> Path.Build.t