Improve "dune describe external-lib-deps" : printing out more information #7478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for another review and to be merged. |
|
same question as in #7480, has this been tested with opam-dune-lint? |
emillon
reviewed
Apr 20, 2023
moyodiallo
force-pushed
the
internal-dune-describe-externals
branch
from
feb5795 to
59af844
Compare
moyodiallo
force-pushed
the
internal-dune-describe-externals
branch
from
59af844 to
6a061d0
Compare
moyodiallo
force-pushed
the
internal-dune-describe-externals
branch
from
6a061d0 to
97b9172
Compare
moyodiallo
force-pushed
the
internal-dune-describe-externals
branch
from
97b9172 to
ee6aa27
Compare
Alizter
reviewed
Jun 27, 2023
moyodiallo
force-pushed
the
internal-dune-describe-externals
branch
from
ee6aa27 to
6a21c2b
Compare
Alizter
reviewed
Jun 27, 2023
| ~f:(fun name -> | ||
| external_resolve db (Lib_name.of_string name) Kind.Optional) | ||
| >>| List.filter_opt) | ||
| | Dune_rules.Lib_dep.Direct (_, name) |
There was a problem hiding this comment.
You should put (lib : Dune_rules.Lib_dep.t) in the match then you can stop prefixing the constructors.
Alizter
reviewed
Jun 27, 2023
moyodiallo
force-pushed
the
internal-dune-describe-externals
branch
from
6a21c2b to
7fc23e1
Compare
moyodiallo
force-pushed
the
internal-dune-describe-externals
branch
3 times, most recently
from
9865cee to
0eec296
Compare
emillon
reviewed
Jul 7, 2023
|
There was a missing |
|
ping? |
moyodiallo
force-pushed
the
internal-dune-describe-externals
branch
from
9055d5d to
44a5eff
Compare
Instead of having only external dependencies, we could also add the
internal dependencies for more information.
Add the extensions of executables
Signed-off-by: Alpha DIALLO <[email protected]>
If a private lib is a dependency and have an external lib as dependency, that information should be known. In order to reach all external dependencies. Signed-off-by: Alpha DIALLO <[email protected]>
Co-authored-by: Etienne Millon <[email protected]> Signed-off-by: Alpha Issiaga DIALLO <[email protected]>
Co-authored-by: Etienne Millon <[email protected]> Signed-off-by: Alpha Issiaga DIALLO <[email protected]>
Signed-off-by: Alpha DIALLO <[email protected]>
Signed-off-by: Alpha DIALLO <[email protected]>
emillon
force-pushed
the
internal-dune-describe-externals
branch
from
44a5eff to
2c67b7a
Compare
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Jul 28, 2023
CHANGES: - Add `dune show rules` as alias of the `dune rules` command. (ocaml/dune#8000, @Alizter) - Fix `%{deps}` to expand properly in `(cat ...)` when containing 2 or more items. (ocaml/dune#8196, @Alizter) - Add `dune show installed-libraries` as an alias of the `dune installed-libraries` command. (ocaml/dune#8135, @Alizter) - Fix the `severity` of error messages sent over RPC which was missing. (ocaml/dune#8193, @Alizter) - Add `dune build --dump-gc-stats FILE` argument to dump garbage collection stats to a named file. (ocaml/dune#8072, @Alizter) - Fix bug with ppx and Reason syntax due to missing dependency in sandboxed action (ocaml/dune#7932, fixes ocaml/dune#7930, @Alizter) - Add `dune describe package-entries` to print all package entries (ocaml/dune#7480, @moyodiallo) - Improve `dune describe external-lib-deps` by adding the internal dependencies for more information. (ocaml/dune#7478, @moyodiallo) - Re-enable background file digests on Windows. The files are now open in a way that prevents race condition around deletion. (ocaml/dune#8262, fixes ocaml/dune#8268, @emillon)
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Jul 31, 2023
CHANGES: - Add `dune show rules` as alias of the `dune rules` command. (ocaml/dune#8000, @Alizter) - Fix `%{deps}` to expand properly in `(cat ...)` when containing 2 or more items. (ocaml/dune#8196, @Alizter) - Add `dune show installed-libraries` as an alias of the `dune installed-libraries` command. (ocaml/dune#8135, @Alizter) - Fix the `severity` of error messages sent over RPC which was missing. (ocaml/dune#8193, @Alizter) - Add `dune build --dump-gc-stats FILE` argument to dump garbage collection stats to a named file. (ocaml/dune#8072, @Alizter) - Fix bug with ppx and Reason syntax due to missing dependency in sandboxed action (ocaml/dune#7932, fixes ocaml/dune#7930, @Alizter) - Add `dune describe package-entries` to print all package entries (ocaml/dune#7480, @moyodiallo) - Improve `dune describe external-lib-deps` by adding the internal dependencies for more information. (ocaml/dune#7478, @moyodiallo) - Re-enable background file digests on Windows. The files are now open in a way that prevents race condition around deletion. (ocaml/dune#8262, fixes ocaml/dune#8268, @emillon)
pmwhite
pushed a commit
to pmwhite/dune
that referenced
this pull request
Aug 10, 2023
…tion (ocaml#7478) * refactor: improve "dune describe external-lib-deps" Instead of having only external dependencies, we could also add the internal dependencies for more information. If a private lib is a dependency and have an external lib as dependency, that information should be known. In order to reach all external dependencies. Signed-off-by: Alpha DIALLO <[email protected]> Co-authored-by: Etienne Millon <[email protected]>
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: - Add `dune show rules` as alias of the `dune rules` command. (ocaml/dune#8000, @Alizter) - Fix `%{deps}` to expand properly in `(cat ...)` when containing 2 or more items. (ocaml/dune#8196, @Alizter) - Add `dune show installed-libraries` as an alias of the `dune installed-libraries` command. (ocaml/dune#8135, @Alizter) - Fix the `severity` of error messages sent over RPC which was missing. (ocaml/dune#8193, @Alizter) - Add `dune build --dump-gc-stats FILE` argument to dump garbage collection stats to a named file. (ocaml/dune#8072, @Alizter) - Fix bug with ppx and Reason syntax due to missing dependency in sandboxed action (ocaml/dune#7932, fixes ocaml/dune#7930, @Alizter) - Add `dune describe package-entries` to print all package entries (ocaml/dune#7480, @moyodiallo) - Improve `dune describe external-lib-deps` by adding the internal dependencies for more information. (ocaml/dune#7478, @moyodiallo) - Re-enable background file digests on Windows. The files are now open in a way that prevents race condition around deletion. (ocaml/dune#8262, fixes ocaml/dune#8268, @emillon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having only external dependencies, we could also add the internal dependencies for more information.
This is related to ocurrent/opam-dune-lint#46.