Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Show number of failed jobs during build #6242

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Oct 15, 2022

Looks like this if there are failures:

Done: 83% (3217/3849, 632 left, 1 failed) (jobs: 0)

and looks like this if there are none:

Done: 83% (3217/3849, 632 left) (jobs: 0)

@Alizter Alizter requested a review from rgrinberg October 15, 2022 19:25
@Alizter Alizter force-pushed the ps/rr/feature__show_number_of_failed_jobs_during_build branch from 64d7b49 to 0ac94bb Compare October 17, 2022 22:53
@rgrinberg rgrinberg requested a review from snowleopard October 18, 2022 22:21
@Alizter Alizter force-pushed the ps/rr/feature__show_number_of_failed_jobs_during_build branch from 0ac94bb to 7571af6 Compare October 19, 2022 22:45
@rgrinberg rgrinberg added this to the 3.6.0 milestone Oct 19, 2022
@Alizter Alizter force-pushed the ps/rr/feature__show_number_of_failed_jobs_during_build branch 3 times, most recently from 4340a43 to 424a020 Compare October 24, 2022 01:13
Copy link
Collaborator

@snowleopard snowleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Alizter Alizter force-pushed the ps/rr/feature__show_number_of_failed_jobs_during_build branch from 424a020 to 1569a69 Compare October 24, 2022 22:17
@rgrinberg
Copy link
Member

Update CHANGES please

Looks like this if there are failures:
```sh
Done: 83% (3849/3849, 632 left, 1 failed) (jobs: 0)
```
and looks like this if there are none:
```sh
Done: 83% (3849/3849, 632 left) (jobs: 0)
```

Signed-off-by: Ali Caglayan <[email protected]>

ps-id: 3e417800-f442-4a4e-975a-1c165cfbbc1a
@Alizter Alizter force-pushed the ps/rr/feature__show_number_of_failed_jobs_during_build branch from 1569a69 to 80d9bab Compare October 24, 2022 22:38
@rgrinberg rgrinberg merged commit 2cbd277 into ocaml:main Oct 24, 2022
@Alizter Alizter deleted the ps/rr/feature__show_number_of_failed_jobs_during_build branch October 24, 2022 23:12
This was referenced Oct 25, 2022
emillon added a commit to emillon/opam-repository that referenced this pull request Nov 14, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.6.0)

CHANGES:

- Forbid multiple instances of dune running concurrently in the same workspace.
  (ocaml/dune#6360, fixes ocaml/dune#236, @rgrinberg)

- Allow promoting into source directories specified by `subdir` (ocaml/dune#6404, fixes
  ocaml/dune#3502, @rgrinberg)

- Make dune describe workspace return the correct root path
  (ocaml/dune#6380, fixes ocaml/dune#6379, @esope)

- Introduce a `$ dune ocaml top-module` subcommand to load modules directly
  without sealing them behind the signature. (ocaml/dune#5940, @rgrinberg)

- [ctypes] do not mangle user written names in the ctypes stanza (ocaml/dune#6374, fixes
  ocaml/dune#5561, @rgrinberg)

- Support `CLICOLOR` and `CLICOLOR_FORCE` to enable/disable/force ANSI
  colors. (ocaml/dune#6340, fixes ocaml/dune#6323, @MisterDA).

- Forbid private libraries with `(package ..)` set from depending on private
  libraries that don't belong to a package (ocaml/dune#6385, fixes ocaml/dune#6153, @rgrinberg)

- Allow `Byte_complete` binaries to be installable (ocaml/dune#4873, @AltGr, @rgrinberg)

- Revive `$ dune external-lib-deps` under `$ dune describe external-lib-deps`.
  (ocaml/dune#6045, @moyodiallo)

- Fix running inline tests in bytecode mode (ocaml/dune#5622, fixes ocaml/dune#5515, @dariusf)

- [ctypes] always re-run `pkg-config` because we aren't tracking its external
  dependencies (ocaml/dune#6052, @rgrinberg)

- [ctypes] remove dependency on configurator in the generated rules (ocaml/dune#6052,
  @rgrinberg)

- Build progress status now shows number of failed jobs (ocaml/dune#6242, @Alizter)

- Allow absolute build directories to find public executables. For example,
  those specified with `(deps %{bin:...})` (ocaml/dune#6326, @anmonteiro)

- Create a fake socket file `_build/.rpc/dune` on windows to allow rpc clients
  to connect using the build directory. (ocaml/dune#6329, @rgrinberg)

- Prevent crash if absolute paths are used in the install stanza and in
  recursive globs. These cases now result in a user error. (ocaml/dune#6331, @gridbugs)

- Add `(glob_files <glob>)` and `(glob_files_rec <glob>)` terms to the `files`
  field of the `install` stanza (ocaml/dune#6250, closes ocaml/dune#6018, @gridbugs)

- Allow `:standard` in the `(modules)` field of the `coq.pp` stanza (ocaml/dune#6229,
  fixes ocaml/dune#2414, @Alizter)

- Fix passing of flags to dune coq top (ocaml/dune#6369, fixes ocaml/dune#6366, @Alizter)

- Extend the promotion CLI to a `dune promotion` group: `dune promote` is moved
  to `dune promotion apply` (the former still works) and the new `dune promotion
  diff` command can be used to just display the promotion without applying it.
  (ocaml/dune#6160, fixes ocaml/dune#5368, @emillon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants