Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repro case for #6153 #6157

Closed
wants to merge 2 commits into from
Closed

Add repro case for #6153 #6157

wants to merge 2 commits into from

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Sep 21, 2022

No description provided.

@rgrinberg
Copy link
Member

@emillon pushed a fix. Thanks for the repro

emillon and others added 2 commits October 21, 2022 18:32
Checking if there's a single library being pulled from the installed and
workspace scope was done incorrectly. It was failing for libraries that
could not introduce overlaps because they weren't found.

Signed-off-by: Rudi Grinberg <[email protected]>
@rgrinberg rgrinberg added this to the 3.6.0 milestone Oct 22, 2022
@rgrinberg rgrinberg linked an issue Oct 22, 2022 that may be closed by this pull request
@rgrinberg
Copy link
Member

Actually, scratch my "fix". The real issue is that a library with (package ..) set cannot depend on a library without (package ..). I'll send a PR to fix this.

@rgrinberg
Copy link
Member

Merged a simpler test case.

@rgrinberg rgrinberg closed this Nov 5, 2022
@emillon emillon deleted the repro-6153 branch November 5, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected find result concerning included module
2 participants