Warn when dune-project does not exist #5343

emillon · 2022-01-13T16:37:24Z

We used to display a message when creating or editing dune-project files, but now that we do not do this anymore (#4239), a "default" dune-project is assumed silently. This PR adds a warning when it happens. This warning is fatal when --release is passed.

emillon · 2022-01-13T16:40:51Z

(as discussed with @jeremiedimino during the dev meeting)

src/dune_engine/source_tree.ml

ghost · 2022-01-13T17:38:31Z

BTW, just a thought: in the doc we say that Dune requires either a dune-project file or a dune-workspace to operate. If we warn when no dune-project file is present, then Dune basically always require a dune-project file. We should either update the doc or remove the warning case and just error out in release mode.

emillon · 2022-01-14T09:09:25Z

BTW, just a thought: in the doc we say that Dune requires either a dune-project file or a dune-workspace to operate. If we warn when no dune-project file is present, then Dune basically always require a dune-project file. We should either update the doc or remove the warning case and just error out in release mode.

Yes, I'm not sure about this either. TBH it feels a bit late to add a breaking change for dune 3, too. An alternative is to put this aside for now and add a check on opam-repo-ci if there's not one already.

rgrinberg · 2022-01-24T04:18:36Z

What's the verdict here? Personally I'm in favor of the change, but we can go either way here.

snowleopard · 2022-01-24T12:50:21Z

In the interest of not pushing too much into Dune 3.0, I'm leaning towards postponing this for now.

rgrinberg · 2022-01-24T18:03:31Z

The problem is that the current situation with project files is unsatisfying. On one hand, we stopped generating dune-project files, on the other hand, we made no effort to remind users that they now need to write these files themselves. It's error prone.

snowleopard · 2022-01-24T18:28:58Z

@rgrinberg You say that the current situation is error prone. Could you give an example of an error caused by silently using the "default" dune-project? I'd think that the default one coincides with the generated one but I guess it's not so.

rgrinberg · 2022-01-24T18:30:32Z

I think the issue is that one can develop without the dune-project file, and even attempt to release it to opam. Only then they will observe that the dune-project file is absent. That's a lot of time wasted on a faulty release.

snowleopard · 2022-01-24T18:37:42Z

I'm sure I'm missing something obvious but why is it bad to release a project without dune-project to Opam? Dune doesn't require it at the moment. Do other tools need it?

rgrinberg · 2022-01-24T19:31:32Z

If you release a package without a project file, the rules to build that project will be different depending on the version of dune used to build it. We try to avoid that as much as possible. Which is why ask the user to explicitly set the dune language in the project file.

snowleopard · 2022-01-24T21:07:38Z

Ah, of course, I get it now.

One might argue that this should then be a prerequisite for uploading a package to Opam. After all, one might make the same mistake by preparing a package for upload manually (or with some other tool).

Warning about a missing dune-project file when building any project seems somewhat annoying to me. I may be just playing and never intend for my toy project to go to Opam yet Dune will be yelling at me.

rgrinberg · 2022-01-24T21:13:27Z

Yes, one group of users will surely be inconvenienced no matter what we do. In this case, we are deciding to inconvenience those with small private projects. Those users will now need to $ echo "(lang dune x.y)" > dune-project to silence the warning.

Note that it's not just about uploading to opam. The package might not be in opam, but available through github and therefore usable through opam-monorepo or git submodules.

snowleopard · 2022-01-24T22:42:41Z

Yes, one group of users will surely be inconvenienced no matter what we do.

Indeed.

How about the following crazy (?) idea. It seems like Dune picking the latest available lang dune when none is specified is the root of the problem here. So, what if starting from 3.0, Dune will default to picking the (lang dune 3.0) forever? If you want a newer version, you need to specify it in the dune-project file.

snowleopard · 2022-01-24T22:51:07Z

(Yeah, that's probably too crazy: in the end, it will force everyone to have the dune-project file but in a confusing and roundabout way.)

rgrinberg · 2022-01-25T00:22:25Z

Yes, I think the original compromise is good. To alleviate the pain for private projects, we already have dune init to quickly generation project files. We could also introduce global dune config to silence some warnings.

emillon · 2022-01-25T09:25:05Z

For examples of cases where this was an issue, see ocaml/opam-repository#20439. If we could get a patch we're confident with, I think that this should be part of 3.0 but I wasn't able to get to the right implementation. It shouldn't delay 3.0 too much. We can add the warning later and make it fatal for 4.0.
In the meantime, we can solve that on opam-repository in the meantime by adding a lint check (depend on dune, no dune-project at root). It's OK if the lint check is not perfect in some corner cases but we definitely don't want a buggy check in dune 3.0.

snowleopard · 2022-01-25T12:39:42Z

Thanks, @emillon!

I'd like to mention one other idea we discussed with Jeremie at some point: make it possible to declare (lang dune x.y.z) directly in the dune file. For simple projects, that may be a preferable approach because that keeps the number of administrative files low. Of course, this complicates the implementation/docs even further, so it's just a thought for the future, not for 3.0.

rgrinberg · 2022-01-25T17:25:44Z

It's OK if the lint check is not perfect in some corner cases but we definitely don't want a buggy check in dune 3.0.

So the check in this PR is flawed?

I'd like to mention one other idea we discussed with Jeremie at some point: make it possible to declare (lang dune x.y.z) directly in the dune file. For simple projects, that may be a preferable approach because that keeps the number of administrative files low. Of course, this complicates the implementation/docs even further, so it's just a thought for the future, not for 3.0.

That would be hard to implement because we would need to evaluate dune files quite early for such "inline" projects. However, we can adjust your proposal to make it both easier to implement, and imho, more natural. What about allowing to include dune contents in the dune-project file instead? For example:

(lang dune x.y)
(inline_dune enabled)

(rules
 (dir1/foo (executable (name foo)..)
 (dir2/bar (library (name bar))..)
 ..)

snowleopard · 2022-01-26T02:07:56Z

That would be hard to implement because we would need to evaluate dune files quite early for such "inline" projects. However, we can adjust your proposal to make it both easier to implement, and imho, more natural. What about allowing to include dune contents in the dune-project file instead?

I agree that your variant may be easier to implement but I'm less sure that it's more natural. To me, dune files are the most basic specification files in Dune, which one should reach out for when starting out a simple project; dune-project and dune-workspace files are needed for more complex scenarios. So, personally, if there is a way to stick to just one file in a project, I'd rather use dune instead of dune-project.

emillon · 2022-01-26T09:46:24Z

So the check in this PR is flawed?

Yes. I was confident with the first version (since it used the same path as the former warning), but Jeremie wasn't. Doing the check at Dune_project.load time seems cleaner but it outputs the warning in different places. It's probably innocuous to infer a project without a dune-project file if no dune files are interpreted.

make it possible to declare (lang dune x.y.z) directly in the dune file.

This could be a nice shortcut but it's a different feature from this PR so I think we should discuss that in a new issue or at the next dev meeting.

rgrinberg · 2022-02-06T04:46:33Z

Can I get a review from either @emillon or @snowleopard

emillon

I think that it sounds fine but I'm not super confident about the feature anymore 😅. It looks like we need to do something about dune init - either bypass the check in that command, or create a dune-project file when one does not exist.

rgrinberg · 2022-02-07T16:03:22Z

What's wrong with the dune init behaviour? If it warns that the project file is missing then so be it?

emillon · 2022-02-07T17:00:53Z

When I'm running dune init, I get a message that the dune-project file does not exist. Fixing this requires knowing how a dune project works, but the point of using something like dune init is to avoid having to know that.
That makes sense, but this is not a great experience if this is your first interaction with the tool. This can be fixed separately of course.

rgrinberg · 2022-02-07T18:25:23Z

Fixing this requires knowing how a dune project works, but the point of using something like dune init is to avoid having to know that.

I'm not sure "dune init" substitutes for knowledge of dune-project files. It only makes this job a little less tedious.

What are the objections against this warning again? In my eyes it only affects a tiny subset of users and it has the potential to save all of them a lot of time when publishing packages.

snowleopard · 2022-02-07T18:30:12Z

@rgrinberg If the warning says "run dune init to create dune-project file" and running dune init gives you exactly the same warning again, that doesn't seem great :)

rgrinberg · 2022-02-08T02:13:49Z

If the warning says "run dune init to create dune-project file" and running dune init gives you exactly the same warning again, that doesn't seem great

Actually, it doesn't do that because dune init doesn't access the Source_tree. Those warnings are from running other dune commands in the dune init test. Nevertheless, I added a commit that silences such warnings when dune init is running.

rgrinberg · 2022-02-08T15:36:29Z

In other words, this PR is ready and I will merge unless there are any objections.

src/dune_engine/clflags.ml

src/dune_engine/clflags.mli

bin/common.ml

src/dune_engine/source_tree.ml

snowleopard · 2022-02-08T18:39:50Z

test/blackbox-tests/test-cases/dune-init.t/run.t

@@ -20,6 +20,9 @@ Can init a public library
 Can build the public library

  $ (cd _test_lib_dir && touch test_lib.opam && dune build)
+  Warning: No dune-project file has been found. A default one is assumed but


I'm confused: I thought the plan was for dune init do the right thing, i.e. create the dune-project file too. Why isn't it created here?

dune init creates the project once it is called with the project argument.

Ah, I see. I think we should suggest that and test that our suggestion works.

I added a suggestion. dune init project is already tested elsewhere, it seems overkill to extract a command out of a printed hint and run it (if that's what you meant)

I only meant that we should test that what we suggest works (not that we need to extract the suggestion, I agree that's an overkill).

We could also make the name argument to dune init project optional. Would make it easier for users to silence the warning.

snowleopard

Overall looks good but I added a couple of suggestions/questions.

src/dune_engine/clflags.mli

We used to display a message when creating or editing dune-project files, but now that we do not do this anymore, a "default" dune-project is assumed silently. This PR adds a warning when it happens. This warning is fatal when --release is passed. Signed-off-by: Etienne Millon <[email protected]>

Signed-off-by: Etienne Millon <[email protected]>

Signed-off-by: Rudi Grinberg <[email protected]>

@kit-ty-kate

…e-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.0.0) CHANGES: - Remove `uchar` and `seq` dummy ocamlfind libraries from dune's builtin library database (ocaml/dune#5260, @kit-ty-kate) - Add a `DUNE_DIFF_COMMAND` environment variable to match `--diff-command` command-line parameter (@raphael-proust, fix ocaml/dune#5369, ocaml/dune#5375) - Add support for odoc-link rules (ocaml/dune#5045, @lubegasimon) - Dune will no longer generate documentation for hidden modules (ocaml/dune#5045, @lubegasimon) - Parse the `native_pack_linker` field of `ocamlc -config` (ocaml/dune#5281, @TheLortex) - Fix plugins with dot in the name (ocaml/dune#5182, @bobot, review @rgrinberg) - Don't generate the dune-site build part when not needed (ocaml/dune#4861, @bobot, review @kit-ty-kate) - Fix installation of implementations of virtual libraries (ocaml/dune#5150, fix ocaml/dune#3636, @rgrinberg) - Run tests in all modes defined. Previously, jsoo was excluded. (@hhugo, ocaml/dune#5049, fix ocaml/dune#4951) - Allow to configure the alias to run the jsoo tests (@hhugo, ocaml/dune#5049, ocaml/dune#4999) - Set jsoo compilation flags in the `env` stanza (@hhugo, ocaml/dune#5049, ocaml/dune#1613) - Allow to configure jsoo separate compilation in the `env` stanza. Previously, it was hard coded to always be enabled in the `dev` profile. (@hhugo, ocaml/dune#5049, fix ocaml/dune#970) - Fix build-info version in jsoo executables (@hhugo, ocaml/dune#5049, fix ocaml/dune#4444) - Pass `-no-check-prims` when building bytecode for jsoo (@hhugo, ocaml/dune#5049, ocaml/dune#4027) - Fix jsoo builds when dynamically linked foreign archives are disabled (@hhugo, ocaml/dune#5049) - Disallow empty packages starting from 3.0. Empty packages may be re-enabled by adding the `(allow_empty)` to the package stanza in the dune-project file. (ocaml/dune#4867, fix ocaml/dune#2882, @kit-ty-kate, @rgrinberg) - Add `link_flags` field to the `executable` field of `inline_tests` (ocaml/dune#5088, fix ocaml/dune#1530, @jvillard) - In watch mode, use fsevents instead of fswatch on OSX (ocaml/dune#4937, ocaml/dune#4990, fixes ocaml/dune#4896 @rgrinberg) - Remove `inotifywait` watch mode backend on Linux. We now use the inotify API exclusively (ocaml/dune#4941, @rgrinberg) - Report cycles between virtual libraries and their implementation (ocaml/dune#5050, fixes ocaml/dune#2896, @rgrinberg) - Warn when lang versions have an ignored suffix. `(lang dune 2.3.4)` or `(lang dune 2.3suffix)` were silently parsed as `2.3` and we know suggest to remove the prefix. (ocaml/dune#5040, @emillon) - Allow users to specify dynamic dependencies in rules. For example `(deps %{read:foo.gen})` (ocaml/dune#4662, fixes ocaml/dune#4089, @jeremiedimino) - Sandbox infer rules for menhir. Fixes possible "inconsistent assumptions" errors (ocaml/dune#5015, @rgrinberg) - Experimental support for ctypes stubs (ocaml/dune#3905, fixes ocaml/dune#135, @mbacarella) - Fix interpretation of `binaries` defined in the `env stanza`. Binaries defined in `x/dune` wouldn't be visible in `x/*/**/dune. (ocaml/dune#4975, fixes ocaml/dune#4976, @Leonidas-from-XIV, @rgrinberg) - Do not list private libraries in package listings (ocaml/dune#4945, fixes ocaml/dune#4799, @rgrinberg) - Allow spaces in cram test paths (ocaml/dune#4980, fixes ocaml/dune#4162, @rgrinberg) - Improve error handling of misbehaving cram scripts. (ocaml/dune#4981, fix ocaml/dune#4230, @rgrinberg) - Fix `foreign_stubs` inside a `tests` stanza. Previously, dune would crash when this field was present (ocaml/dune#4942, fix ocaml/dune#4946, @rgrinberg) - Add the `enabled_if` field to `inline_tests` within the `library` stanza. This allows us to disable executing the inline tests while still allowing for compilation (ocaml/dune#4939, @rgrinberg) - Generate a `dune-project` when initializing projects with `dune init proj ...` (ocaml/dune#4881, closes ocaml/dune#4367, @shonfeder) - Allow spaces in the directory argument of the `subdir` stanza (ocaml/dune#4943, fixes ocaml/dune#4907, @rgrinberg) - Add a `%{toolchain}` expansion variable (ocaml/dune#4899, fixes ocaml/dune#3949, @rgrinberg) - Include dependencies of executables when creating toplevels (either `dune top` or `dune utop`) (ocaml/dune#4882, fixes ocaml/dune#4872, @Gopiancode) - Fixes `opam` META file requires entry for private libs (ocaml/dune#4841, fixes ocaml/dune#4839, @toots) - Fixes `dune exec` not adding .exe on Windows (ocaml/dune#4371, fixes ocaml/dune#3322, @MisterDA) - Allow multiple cinaps stanzas in the same directory (ocaml/dune#4460, @rgrinberg) - Fix `$ dune subst` in empty git repositories (ocaml/dune#4441, fixes ocaml/dune#3619, @rgrinberg) - Improve interpretation of ansi escape sequence when spawning processes (ocaml/dune#4408, fixes ocaml/dune#2665, @rgrinberg) - Allow `(package pkg)` in dependencies even if `pkg` is an installed package (ocaml/dune#4170, @bobot) - Allow `%{version:pkg}` to work for external packages (ocaml/dune#4104, @kit-ty-kate) - Add `(glob_files_rec <dir>/<glob>)` for globbing files recursively (ocaml/dune#4176, @jeremiedimino) - Automatically generate empty `.mli` files for executables and tests (ocaml/dune#3768, fixes ocaml/dune#3745, @craigfe) - Add `ocaml` command subgroup for OCaml related commands such as `utop`, `top`, and `merlin` (ocaml/dune#3936, @rgrinberg). - Detect unknown variables more eagerly (ocaml/dune#4184, @jeremiedimino) - Improve location of variables and macros in error messages (ocaml/dune#4205, @jeremiedimino) - Auto-detect `dune-project` files as `dune` files in Emacs (ocaml/dune#4222, @shonfeder) - Dune no longer automatically create or edit `dune-project` files (ocaml/dune#4239, fixes ocaml/dune#4108, @jeremiedimino) - Warn if `dune-project` is not found (fatal in release mode) (ocaml/dune#5343, @emillon) - Cleanup temporary files after running `$ dune exec`. (ocaml/dune#4260, fixes ocaml/dune#4243, @rgrinberg) - Add a new subcommand `dune ocaml dump-dot-merlin` that prints a mix of all the merlin configuration of a directory (defaulting to the current directory) in the Merlin configuration syntax. (ocaml/dune#4250, @voodoos) - Enable cram tests by default (ocaml/dune#4262, @rgrinberg) - Drop support for opam 1.x (ocaml/dune#4280, @jeremiedimino) - Stop calling `ocamlfind` to determine the library search path or library installation directory. This makes the behavior of Dune simpler and more reproducible (ocaml/dune#4281, @jeremiedimino) - Remove the `external-lib-deps` command. This command was only approximative and the cost of maintainance was getting too high. We removed it to make room for new more important features (ocaml/dune#4298, @jeremiedimino) - It is now possible to define action dependencies through a chain of aliases. (ocaml/dune#4303, @aalekseyev) - If an .ml file is not used by an executable, Dune no longer report parsing error in this file (ocaml/dune#4330, @jeremiedimino) - Add support for sandboxing using hard links (ocaml/dune#4360, Andrey Mokhov) - Fix dune crash when `subdir` is an absolute path (ocaml/dune#4366, @anmonteiro) - Changed the implementation of actions attached to aliases, as in `(rule (alias runtest) (action (run ./test)))`. A visible result for users is that such actions are now memoized for longer. For instance: ``` $ echo '(rule (alias runtest) (action (echo "X=%{env:X=0}\n")))` > dune $ X=1 dune runtest X=1 $ X=2 dune runtest X=2 $ X=1 dune runtest ``` Previously, Dune would have re-executed the action again at the last line. Now it remembers the result of the first execution. - Fix a bug where dune would always re-run all actions that produce symlinks, even if their dependencies did not change. (ocaml/dune#4405, @aalekseyev) - Fix a bug that was causing Dune to re-hash generated files more often than necessary (ocaml/dune#4419, @jeremiedimino) - Fields allowed in the config file are now also allowed in the workspace file (ocaml/dune#4426, @jeremiedimino) - Add options to control how Dune should handle stdout and stderr of actions when then succeed. It is now possible to ask Dune to ignore the stdout of actions when they succeed or to request that the stderr of actions must be empty. This allows to reduce the noise of large builds (ocaml/dune#4422, ocaml/dune#4515, @jeremiedimino) - The `@all` alias no longer depends directly on copies of files from the source directory (ocaml/dune#4461, @nojb) - Allow dune-file as an alternative file name for dune files (needs to be enabled in the dune-project file) (ocaml/dune#4428, @nojb) - Drop support for upgrading jbuilder projects (ocaml/dune#4473, @jeremiedimino) - Extend the environment variable `BUILD_PATH_PREFIX_MAP` to rewrite the root of the build dir (or sandbox) to `/workspace_root` (ocaml/dune#4466, @jeremiedimino) - Simplify the implementation of build cache. We stop using the cache daemon to access the cache and instead write to and read from it directly. The new cache implementation is based on Jenga's cache library, which was thoroughly tested on large-scale builds. Using Jenga's cache library will also make it easier for us to port Jenga's cloud cache to Dune. (ocaml/dune#4443, ocaml/dune#4465, Andrey Mokhov) - More informative error message when Dune can't read a target that's supposed to be produced by the action. Old message is still produced on ENOENT, but other errors deserve a more detailed report. (ocaml/dune#4501, @aalekseyev) - Fixed a bug where a sandboxed action would fail if it declares no dependencies in its initial working directory or any directory it `chdir`s into. (ocaml/dune#4509, @aalekseyev) - Fix a crash when clearing temporary directories (ocaml/dune#4489, ocaml/dune#4529, Andrey Mokhov) - Dune now memoizes all errors when running in the file-watching mode. This speeds up incremental rebuilds but may be inconvenient in rare cases, e.g. if a build action fails due to a spurious error, such as running out of memory. Right now, the only way to force such actions to be rebuilt is to restart Dune, which clears all memoized errors. In future, we would like to provide a way to rerun all actions failed due to errors without restarting the build, e.g. via a Dune RPC call. (ocaml/dune#4522, Andrey Mokhov) - Remove `dune compute`. It was broken and unused (ocaml/dune#4540, @jeremiedimino) - No longer generate an approximate merlin files when computing the ocaml flags fails, for instance because they include the contents of a file that failed to build. This was a niche feature and it was getting in the way of making Dune's core better. (ocaml/dune#4607, @jeremiedimino) - Make Dune display the progress indicator in all output modes except quiet (ocaml/dune#4618, @aalekseyev) - Report accurate process timing information in trace mode (enabled with `--trace-file`) (ocaml/dune#4517, @rgrinberg) - Do not log `live_words` and `free_words` in trace file. This allows using `Gc.quick_stat` which does not scan the heap. (ocaml/dune#4643, @emillon) - Don't let command run by Dune observe the environment variable `INSIDE_EMACS` in order to improve reproducibility (ocaml/dune#4680, @jeremiedimino) - Fix `root_module` when used in public libraries (ocaml/dune#4685, fixes ocaml/dune#4684, @rgrinberg, @craigfe) - Fix `root_module` when used with preprocessing (ocaml/dune#4683, fixes ocaml/dune#4682, @rgrinberg, @craigfe) - Display Coq profile flags in `dune printenv` (ocaml/dune#4767, @ejgallego) - Introduce mdx stanza 0.2, requiring mdx >= 1.9.0, with a new generic `deps` field and the possibility to statically link `libraries` in the test executable. (ocaml/dune#3956, ocaml/dune#5391, fixes ocaml/dune#3955) - Improve lookup of optional or disabled binaries. Previously, we'd treat every executable with missing libraries as optional. Now, we treat make sure to look at the library's optional or enabled_if status (ocaml/dune#4786). - Always use 7 char hash prefix in build info version (ocaml/dune#4857, @jberdine, fixes ocaml/dune#4855) - Allow to explicitly disable/enable the use of `dune subst` by adding a new `(subst <disable|enable>)` stanza to the `dune-project` file. (ocaml/dune#4864, @kit-ty-kate) - Simplify the way `dune` discovers the root of the workspace. It now stops at the first `dune-workspace` file it encounters, and fails if it finds neither a `dune-workspace` nor a `dune-project` file (ocaml/dune#4921, fixes ocaml/dune#4459, @jeremiedimino) - Dune no longer reads installed META files for libraries distributed with the compiler, instead using its own internal database. (ocaml/dune#4946, @nojb) - Add support for `(empty_module_interface_if_absent)` in executable and library stanzas. (ocaml/dune#4955, @nojb) - Add support for `%{bin-available:...}` (ocaml/dune#4995, @jeremiedimino) - Make sure running `git` or `hg` in a sandboxed action, such as a cram test cannot escape the sandbox and pick up some random git or mercurial repository on the file system (ocaml/dune#4996, @jeremiedimino) - Allow `%{read:...}` in more places such as `(enabled_if ...)` (ocaml/dune#4994, @jeremiedimino) - Run each action in its own process group so that we don't leave stray processes behind when killing actions (ocaml/dune#4998, @jeremiedimino) - Add an option `expand_aliases_in_sandbox` (ocaml/dune#5003, @jeremiedimino) - Allow to cancel the initial scan via Control+C (ocaml/dune#4460, fixes ocaml/dune#4364 @jeremiedimino) - Add experimental support for directory targets (ocaml/dune#3316, ocaml/dune#5025, Andrey Mokhov), enabled via `(using directory-targets 0.1)` in `dune-project`. - Delete old `promote-into`, `promote-until-clean` and `promote-until-clean-into` syntax (ocaml/dune#5091, Andrey Mokhov). - Add link_flags in the env stanza (ocaml/dune#5215) - Bootstrap: ignore errors when trying to remove generated files. (ocaml/dune#5407, @damiendoligez)

@kit-ty-kate

…e-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.0.0) CHANGES: - Remove `uchar` and `seq` dummy ocamlfind libraries from dune's builtin library database (ocaml/dune#5260, @kit-ty-kate) - Add a `DUNE_DIFF_COMMAND` environment variable to match `--diff-command` command-line parameter (@raphael-proust, fix ocaml/dune#5369, ocaml/dune#5375) - Add support for odoc-link rules (ocaml/dune#5045, @lubegasimon) - Dune will no longer generate documentation for hidden modules (ocaml/dune#5045, @lubegasimon) - Parse the `native_pack_linker` field of `ocamlc -config` (ocaml/dune#5281, @TheLortex) - Fix plugins with dot in the name (ocaml/dune#5182, @bobot, review @rgrinberg) - Don't generate the dune-site build part when not needed (ocaml/dune#4861, @bobot, review @kit-ty-kate) - Fix installation of implementations of virtual libraries (ocaml/dune#5150, fix ocaml/dune#3636, @rgrinberg) - Run tests in all modes defined. Previously, jsoo was excluded. (@hhugo, ocaml/dune#5049, fix ocaml/dune#4951) - Allow to configure the alias to run the jsoo tests (@hhugo, ocaml/dune#5049, ocaml/dune#4999) - Set jsoo compilation flags in the `env` stanza (@hhugo, ocaml/dune#5049, ocaml/dune#1613) - Allow to configure jsoo separate compilation in the `env` stanza. Previously, it was hard coded to always be enabled in the `dev` profile. (@hhugo, ocaml/dune#5049, fix ocaml/dune#970) - Fix build-info version in jsoo executables (@hhugo, ocaml/dune#5049, fix ocaml/dune#4444) - Pass `-no-check-prims` when building bytecode for jsoo (@hhugo, ocaml/dune#5049, ocaml/dune#4027) - Fix jsoo builds when dynamically linked foreign archives are disabled (@hhugo, ocaml/dune#5049) - Disallow empty packages starting from 3.0. Empty packages may be re-enabled by adding the `(allow_empty)` to the package stanza in the dune-project file. (ocaml/dune#4867, fix ocaml/dune#2882, @kit-ty-kate, @rgrinberg) - Add `link_flags` field to the `executable` field of `inline_tests` (ocaml/dune#5088, fix ocaml/dune#1530, @jvillard) - In watch mode, use fsevents instead of fswatch on OSX (ocaml/dune#4937, ocaml/dune#4990, fixes ocaml/dune#4896 @rgrinberg) - Remove `inotifywait` watch mode backend on Linux. We now use the inotify API exclusively (ocaml/dune#4941, @rgrinberg) - Report cycles between virtual libraries and their implementation (ocaml/dune#5050, fixes ocaml/dune#2896, @rgrinberg) - Warn when lang versions have an ignored suffix. `(lang dune 2.3.4)` or `(lang dune 2.3suffix)` were silently parsed as `2.3` and we know suggest to remove the prefix. (ocaml/dune#5040, @emillon) - Allow users to specify dynamic dependencies in rules. For example `(deps %{read:foo.gen})` (ocaml/dune#4662, fixes ocaml/dune#4089, @jeremiedimino) - Sandbox infer rules for menhir. Fixes possible "inconsistent assumptions" errors (ocaml/dune#5015, @rgrinberg) - Experimental support for ctypes stubs (ocaml/dune#3905, fixes ocaml/dune#135, @mbacarella) - Fix interpretation of `binaries` defined in the `env stanza`. Binaries defined in `x/dune` wouldn't be visible in `x/*/**/dune. (ocaml/dune#4975, fixes ocaml/dune#4976, @Leonidas-from-XIV, @rgrinberg) - Do not list private libraries in package listings (ocaml/dune#4945, fixes ocaml/dune#4799, @rgrinberg) - Allow spaces in cram test paths (ocaml/dune#4980, fixes ocaml/dune#4162, @rgrinberg) - Improve error handling of misbehaving cram scripts. (ocaml/dune#4981, fix ocaml/dune#4230, @rgrinberg) - Fix `foreign_stubs` inside a `tests` stanza. Previously, dune would crash when this field was present (ocaml/dune#4942, fix ocaml/dune#4946, @rgrinberg) - Add the `enabled_if` field to `inline_tests` within the `library` stanza. This allows us to disable executing the inline tests while still allowing for compilation (ocaml/dune#4939, @rgrinberg) - Generate a `dune-project` when initializing projects with `dune init proj ...` (ocaml/dune#4881, closes ocaml/dune#4367, @shonfeder) - Allow spaces in the directory argument of the `subdir` stanza (ocaml/dune#4943, fixes ocaml/dune#4907, @rgrinberg) - Add a `%{toolchain}` expansion variable (ocaml/dune#4899, fixes ocaml/dune#3949, @rgrinberg) - Include dependencies of executables when creating toplevels (either `dune top` or `dune utop`) (ocaml/dune#4882, fixes ocaml/dune#4872, @Gopiancode) - Fixes `opam` META file requires entry for private libs (ocaml/dune#4841, fixes ocaml/dune#4839, @toots) - Fixes `dune exec` not adding .exe on Windows (ocaml/dune#4371, fixes ocaml/dune#3322, @MisterDA) - Allow multiple cinaps stanzas in the same directory (ocaml/dune#4460, @rgrinberg) - Fix `$ dune subst` in empty git repositories (ocaml/dune#4441, fixes ocaml/dune#3619, @rgrinberg) - Improve interpretation of ansi escape sequence when spawning processes (ocaml/dune#4408, fixes ocaml/dune#2665, @rgrinberg) - Allow `(package pkg)` in dependencies even if `pkg` is an installed package (ocaml/dune#4170, @bobot) - Allow `%{version:pkg}` to work for external packages (ocaml/dune#4104, @kit-ty-kate) - Add `(glob_files_rec <dir>/<glob>)` for globbing files recursively (ocaml/dune#4176, @jeremiedimino) - Automatically generate empty `.mli` files for executables and tests (ocaml/dune#3768, fixes ocaml/dune#3745, @craigfe) - Add `ocaml` command subgroup for OCaml related commands such as `utop`, `top`, and `merlin` (ocaml/dune#3936, @rgrinberg). - Detect unknown variables more eagerly (ocaml/dune#4184, @jeremiedimino) - Improve location of variables and macros in error messages (ocaml/dune#4205, @jeremiedimino) - Auto-detect `dune-project` files as `dune` files in Emacs (ocaml/dune#4222, @shonfeder) - Dune no longer automatically create or edit `dune-project` files (ocaml/dune#4239, fixes ocaml/dune#4108, @jeremiedimino) - Warn if `dune-project` is not found (fatal in release mode) (ocaml/dune#5343, @emillon) - Cleanup temporary files after running `$ dune exec`. (ocaml/dune#4260, fixes ocaml/dune#4243, @rgrinberg) - Add a new subcommand `dune ocaml dump-dot-merlin` that prints a mix of all the merlin configuration of a directory (defaulting to the current directory) in the Merlin configuration syntax. (ocaml/dune#4250, @voodoos) - Enable cram tests by default (ocaml/dune#4262, @rgrinberg) - Drop support for opam 1.x (ocaml/dune#4280, @jeremiedimino) - Stop calling `ocamlfind` to determine the library search path or library installation directory. This makes the behavior of Dune simpler and more reproducible (ocaml/dune#4281, @jeremiedimino) - Remove the `external-lib-deps` command. This command was only approximative and the cost of maintainance was getting too high. We removed it to make room for new more important features (ocaml/dune#4298, @jeremiedimino) - It is now possible to define action dependencies through a chain of aliases. (ocaml/dune#4303, @aalekseyev) - If an .ml file is not used by an executable, Dune no longer report parsing error in this file (ocaml/dune#4330, @jeremiedimino) - Add support for sandboxing using hard links (ocaml/dune#4360, Andrey Mokhov) - Fix dune crash when `subdir` is an absolute path (ocaml/dune#4366, @anmonteiro) - Changed the implementation of actions attached to aliases, as in `(rule (alias runtest) (action (run ./test)))`. A visible result for users is that such actions are now memoized for longer. For instance: ``` $ echo '(rule (alias runtest) (action (echo "X=%{env:X=0}\n")))` > dune $ X=1 dune runtest X=1 $ X=2 dune runtest X=2 $ X=1 dune runtest ``` Previously, Dune would have re-executed the action again at the last line. Now it remembers the result of the first execution. - Fix a bug where dune would always re-run all actions that produce symlinks, even if their dependencies did not change. (ocaml/dune#4405, @aalekseyev) - Fix a bug that was causing Dune to re-hash generated files more often than necessary (ocaml/dune#4419, @jeremiedimino) - Fields allowed in the config file are now also allowed in the workspace file (ocaml/dune#4426, @jeremiedimino) - Add options to control how Dune should handle stdout and stderr of actions when then succeed. It is now possible to ask Dune to ignore the stdout of actions when they succeed or to request that the stderr of actions must be empty. This allows to reduce the noise of large builds (ocaml/dune#4422, ocaml/dune#4515, @jeremiedimino) - The `@all` alias no longer depends directly on copies of files from the source directory (ocaml/dune#4461, @nojb) - Allow dune-file as an alternative file name for dune files (needs to be enabled in the dune-project file) (ocaml/dune#4428, @nojb) - Drop support for upgrading jbuilder projects (ocaml/dune#4473, @jeremiedimino) - Extend the environment variable `BUILD_PATH_PREFIX_MAP` to rewrite the root of the build dir (or sandbox) to `/workspace_root` (ocaml/dune#4466, @jeremiedimino) - Simplify the implementation of build cache. We stop using the cache daemon to access the cache and instead write to and read from it directly. The new cache implementation is based on Jenga's cache library, which was thoroughly tested on large-scale builds. Using Jenga's cache library will also make it easier for us to port Jenga's cloud cache to Dune. (ocaml/dune#4443, ocaml/dune#4465, Andrey Mokhov) - More informative error message when Dune can't read a target that's supposed to be produced by the action. Old message is still produced on ENOENT, but other errors deserve a more detailed report. (ocaml/dune#4501, @aalekseyev) - Fixed a bug where a sandboxed action would fail if it declares no dependencies in its initial working directory or any directory it `chdir`s into. (ocaml/dune#4509, @aalekseyev) - Fix a crash when clearing temporary directories (ocaml/dune#4489, ocaml/dune#4529, Andrey Mokhov) - Dune now memoizes all errors when running in the file-watching mode. This speeds up incremental rebuilds but may be inconvenient in rare cases, e.g. if a build action fails due to a spurious error, such as running out of memory. Right now, the only way to force such actions to be rebuilt is to restart Dune, which clears all memoized errors. In future, we would like to provide a way to rerun all actions failed due to errors without restarting the build, e.g. via a Dune RPC call. (ocaml/dune#4522, Andrey Mokhov) - Remove `dune compute`. It was broken and unused (ocaml/dune#4540, @jeremiedimino) - No longer generate an approximate merlin files when computing the ocaml flags fails, for instance because they include the contents of a file that failed to build. This was a niche feature and it was getting in the way of making Dune's core better. (ocaml/dune#4607, @jeremiedimino) - Make Dune display the progress indicator in all output modes except quiet (ocaml/dune#4618, @aalekseyev) - Report accurate process timing information in trace mode (enabled with `--trace-file`) (ocaml/dune#4517, @rgrinberg) - Do not log `live_words` and `free_words` in trace file. This allows using `Gc.quick_stat` which does not scan the heap. (ocaml/dune#4643, @emillon) - Don't let command run by Dune observe the environment variable `INSIDE_EMACS` in order to improve reproducibility (ocaml/dune#4680, @jeremiedimino) - Fix `root_module` when used in public libraries (ocaml/dune#4685, fixes ocaml/dune#4684, @rgrinberg, @craigfe) - Fix `root_module` when used with preprocessing (ocaml/dune#4683, fixes ocaml/dune#4682, @rgrinberg, @craigfe) - Display Coq profile flags in `dune printenv` (ocaml/dune#4767, @ejgallego) - Introduce mdx stanza 0.2, requiring mdx >= 1.9.0, with a new generic `deps` field and the possibility to statically link `libraries` in the test executable. (ocaml/dune#3956, ocaml/dune#5391, fixes ocaml/dune#3955) - Improve lookup of optional or disabled binaries. Previously, we'd treat every executable with missing libraries as optional. Now, we treat make sure to look at the library's optional or enabled_if status (ocaml/dune#4786). - Always use 7 char hash prefix in build info version (ocaml/dune#4857, @jberdine, fixes ocaml/dune#4855) - Allow to explicitly disable/enable the use of `dune subst` by adding a new `(subst <disable|enable>)` stanza to the `dune-project` file. (ocaml/dune#4864, @kit-ty-kate) - Simplify the way `dune` discovers the root of the workspace. It now stops at the first `dune-workspace` file it encounters, and fails if it finds neither a `dune-workspace` nor a `dune-project` file (ocaml/dune#4921, fixes ocaml/dune#4459, @jeremiedimino) - Dune no longer reads installed META files for libraries distributed with the compiler, instead using its own internal database. (ocaml/dune#4946, @nojb) - Add support for `(empty_module_interface_if_absent)` in executable and library stanzas. (ocaml/dune#4955, @nojb) - Add support for `%{bin-available:...}` (ocaml/dune#4995, @jeremiedimino) - Make sure running `git` or `hg` in a sandboxed action, such as a cram test cannot escape the sandbox and pick up some random git or mercurial repository on the file system (ocaml/dune#4996, @jeremiedimino) - Allow `%{read:...}` in more places such as `(enabled_if ...)` (ocaml/dune#4994, @jeremiedimino) - Run each action in its own process group so that we don't leave stray processes behind when killing actions (ocaml/dune#4998, @jeremiedimino) - Add an option `expand_aliases_in_sandbox` (ocaml/dune#5003, @jeremiedimino) - Allow to cancel the initial scan via Control+C (ocaml/dune#4460, fixes ocaml/dune#4364 @jeremiedimino) - Add experimental support for directory targets (ocaml/dune#3316, ocaml/dune#5025, Andrey Mokhov), enabled via `(using directory-targets 0.1)` in `dune-project`. - Delete old `promote-into`, `promote-until-clean` and `promote-until-clean-into` syntax (ocaml/dune#5091, Andrey Mokhov). - Add link_flags in the env stanza (ocaml/dune#5215) - Bootstrap: ignore errors when trying to remove generated files. (ocaml/dune#5407, @damiendoligez)

@kit-ty-kate

…e-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.0.0) CHANGES: - Remove `uchar` and `seq` dummy ocamlfind libraries from dune's builtin library database (ocaml/dune#5260, @kit-ty-kate) - Add a `DUNE_DIFF_COMMAND` environment variable to match `--diff-command` command-line parameter (@raphael-proust, fix ocaml/dune#5369, ocaml/dune#5375) - Add support for odoc-link rules (ocaml/dune#5045, @lubegasimon) - Dune will no longer generate documentation for hidden modules (ocaml/dune#5045, @lubegasimon) - Parse the `native_pack_linker` field of `ocamlc -config` (ocaml/dune#5281, @TheLortex) - Fix plugins with dot in the name (ocaml/dune#5182, @bobot, review @rgrinberg) - Don't generate the dune-site build part when not needed (ocaml/dune#4861, @bobot, review @kit-ty-kate) - Fix installation of implementations of virtual libraries (ocaml/dune#5150, fix ocaml/dune#3636, @rgrinberg) - Run tests in all modes defined. Previously, jsoo was excluded. (@hhugo, ocaml/dune#5049, fix ocaml/dune#4951) - Allow to configure the alias to run the jsoo tests (@hhugo, ocaml/dune#5049, ocaml/dune#4999) - Set jsoo compilation flags in the `env` stanza (@hhugo, ocaml/dune#5049, ocaml/dune#1613) - Allow to configure jsoo separate compilation in the `env` stanza. Previously, it was hard coded to always be enabled in the `dev` profile. (@hhugo, ocaml/dune#5049, fix ocaml/dune#970) - Fix build-info version in jsoo executables (@hhugo, ocaml/dune#5049, fix ocaml/dune#4444) - Pass `-no-check-prims` when building bytecode for jsoo (@hhugo, ocaml/dune#5049, ocaml/dune#4027) - Fix jsoo builds when dynamically linked foreign archives are disabled (@hhugo, ocaml/dune#5049) - Disallow empty packages starting from 3.0. Empty packages may be re-enabled by adding the `(allow_empty)` to the package stanza in the dune-project file. (ocaml/dune#4867, fix ocaml/dune#2882, @kit-ty-kate, @rgrinberg) - Add `link_flags` field to the `executable` field of `inline_tests` (ocaml/dune#5088, fix ocaml/dune#1530, @jvillard) - In watch mode, use fsevents instead of fswatch on OSX (ocaml/dune#4937, ocaml/dune#4990, fixes ocaml/dune#4896 @rgrinberg) - Remove `inotifywait` watch mode backend on Linux. We now use the inotify API exclusively (ocaml/dune#4941, @rgrinberg) - Report cycles between virtual libraries and their implementation (ocaml/dune#5050, fixes ocaml/dune#2896, @rgrinberg) - Warn when lang versions have an ignored suffix. `(lang dune 2.3.4)` or `(lang dune 2.3suffix)` were silently parsed as `2.3` and we know suggest to remove the prefix. (ocaml/dune#5040, @emillon) - Allow users to specify dynamic dependencies in rules. For example `(deps %{read:foo.gen})` (ocaml/dune#4662, fixes ocaml/dune#4089, @jeremiedimino) - Sandbox infer rules for menhir. Fixes possible "inconsistent assumptions" errors (ocaml/dune#5015, @rgrinberg) - Experimental support for ctypes stubs (ocaml/dune#3905, fixes ocaml/dune#135, @mbacarella) - Fix interpretation of `binaries` defined in the `env stanza`. Binaries defined in `x/dune` wouldn't be visible in `x/*/**/dune. (ocaml/dune#4975, fixes ocaml/dune#4976, @Leonidas-from-XIV, @rgrinberg) - Do not list private libraries in package listings (ocaml/dune#4945, fixes ocaml/dune#4799, @rgrinberg) - Allow spaces in cram test paths (ocaml/dune#4980, fixes ocaml/dune#4162, @rgrinberg) - Improve error handling of misbehaving cram scripts. (ocaml/dune#4981, fix ocaml/dune#4230, @rgrinberg) - Fix `foreign_stubs` inside a `tests` stanza. Previously, dune would crash when this field was present (ocaml/dune#4942, fix ocaml/dune#4946, @rgrinberg) - Add the `enabled_if` field to `inline_tests` within the `library` stanza. This allows us to disable executing the inline tests while still allowing for compilation (ocaml/dune#4939, @rgrinberg) - Generate a `dune-project` when initializing projects with `dune init proj ...` (ocaml/dune#4881, closes ocaml/dune#4367, @shonfeder) - Allow spaces in the directory argument of the `subdir` stanza (ocaml/dune#4943, fixes ocaml/dune#4907, @rgrinberg) - Add a `%{toolchain}` expansion variable (ocaml/dune#4899, fixes ocaml/dune#3949, @rgrinberg) - Include dependencies of executables when creating toplevels (either `dune top` or `dune utop`) (ocaml/dune#4882, fixes ocaml/dune#4872, @Gopiancode) - Fixes `opam` META file requires entry for private libs (ocaml/dune#4841, fixes ocaml/dune#4839, @toots) - Fixes `dune exec` not adding .exe on Windows (ocaml/dune#4371, fixes ocaml/dune#3322, @MisterDA) - Allow multiple cinaps stanzas in the same directory (ocaml/dune#4460, @rgrinberg) - Fix `$ dune subst` in empty git repositories (ocaml/dune#4441, fixes ocaml/dune#3619, @rgrinberg) - Improve interpretation of ansi escape sequence when spawning processes (ocaml/dune#4408, fixes ocaml/dune#2665, @rgrinberg) - Allow `(package pkg)` in dependencies even if `pkg` is an installed package (ocaml/dune#4170, @bobot) - Allow `%{version:pkg}` to work for external packages (ocaml/dune#4104, @kit-ty-kate) - Add `(glob_files_rec <dir>/<glob>)` for globbing files recursively (ocaml/dune#4176, @jeremiedimino) - Automatically generate empty `.mli` files for executables and tests (ocaml/dune#3768, fixes ocaml/dune#3745, @craigfe) - Add `ocaml` command subgroup for OCaml related commands such as `utop`, `top`, and `merlin` (ocaml/dune#3936, @rgrinberg). - Detect unknown variables more eagerly (ocaml/dune#4184, @jeremiedimino) - Improve location of variables and macros in error messages (ocaml/dune#4205, @jeremiedimino) - Auto-detect `dune-project` files as `dune` files in Emacs (ocaml/dune#4222, @shonfeder) - Dune no longer automatically create or edit `dune-project` files (ocaml/dune#4239, fixes ocaml/dune#4108, @jeremiedimino) - Warn if `dune-project` is not found (fatal in release mode) (ocaml/dune#5343, @emillon) - Cleanup temporary files after running `$ dune exec`. (ocaml/dune#4260, fixes ocaml/dune#4243, @rgrinberg) - Add a new subcommand `dune ocaml dump-dot-merlin` that prints a mix of all the merlin configuration of a directory (defaulting to the current directory) in the Merlin configuration syntax. (ocaml/dune#4250, @voodoos) - Enable cram tests by default (ocaml/dune#4262, @rgrinberg) - Drop support for opam 1.x (ocaml/dune#4280, @jeremiedimino) - Stop calling `ocamlfind` to determine the library search path or library installation directory. This makes the behavior of Dune simpler and more reproducible (ocaml/dune#4281, @jeremiedimino) - Remove the `external-lib-deps` command. This command was only approximative and the cost of maintainance was getting too high. We removed it to make room for new more important features (ocaml/dune#4298, @jeremiedimino) - It is now possible to define action dependencies through a chain of aliases. (ocaml/dune#4303, @aalekseyev) - If an .ml file is not used by an executable, Dune no longer report parsing error in this file (ocaml/dune#4330, @jeremiedimino) - Add support for sandboxing using hard links (ocaml/dune#4360, Andrey Mokhov) - Fix dune crash when `subdir` is an absolute path (ocaml/dune#4366, @anmonteiro) - Changed the implementation of actions attached to aliases, as in `(rule (alias runtest) (action (run ./test)))`. A visible result for users is that such actions are now memoized for longer. For instance: ``` $ echo '(rule (alias runtest) (action (echo "X=%{env:X=0}\n")))` > dune $ X=1 dune runtest X=1 $ X=2 dune runtest X=2 $ X=1 dune runtest ``` Previously, Dune would have re-executed the action again at the last line. Now it remembers the result of the first execution. - Fix a bug where dune would always re-run all actions that produce symlinks, even if their dependencies did not change. (ocaml/dune#4405, @aalekseyev) - Fix a bug that was causing Dune to re-hash generated files more often than necessary (ocaml/dune#4419, @jeremiedimino) - Fields allowed in the config file are now also allowed in the workspace file (ocaml/dune#4426, @jeremiedimino) - Add options to control how Dune should handle stdout and stderr of actions when then succeed. It is now possible to ask Dune to ignore the stdout of actions when they succeed or to request that the stderr of actions must be empty. This allows to reduce the noise of large builds (ocaml/dune#4422, ocaml/dune#4515, @jeremiedimino) - The `@all` alias no longer depends directly on copies of files from the source directory (ocaml/dune#4461, @nojb) - Allow dune-file as an alternative file name for dune files (needs to be enabled in the dune-project file) (ocaml/dune#4428, @nojb) - Drop support for upgrading jbuilder projects (ocaml/dune#4473, @jeremiedimino) - Extend the environment variable `BUILD_PATH_PREFIX_MAP` to rewrite the root of the build dir (or sandbox) to `/workspace_root` (ocaml/dune#4466, @jeremiedimino) - Simplify the implementation of build cache. We stop using the cache daemon to access the cache and instead write to and read from it directly. The new cache implementation is based on Jenga's cache library, which was thoroughly tested on large-scale builds. Using Jenga's cache library will also make it easier for us to port Jenga's cloud cache to Dune. (ocaml/dune#4443, ocaml/dune#4465, Andrey Mokhov) - More informative error message when Dune can't read a target that's supposed to be produced by the action. Old message is still produced on ENOENT, but other errors deserve a more detailed report. (ocaml/dune#4501, @aalekseyev) - Fixed a bug where a sandboxed action would fail if it declares no dependencies in its initial working directory or any directory it `chdir`s into. (ocaml/dune#4509, @aalekseyev) - Fix a crash when clearing temporary directories (ocaml/dune#4489, ocaml/dune#4529, Andrey Mokhov) - Dune now memoizes all errors when running in the file-watching mode. This speeds up incremental rebuilds but may be inconvenient in rare cases, e.g. if a build action fails due to a spurious error, such as running out of memory. Right now, the only way to force such actions to be rebuilt is to restart Dune, which clears all memoized errors. In future, we would like to provide a way to rerun all actions failed due to errors without restarting the build, e.g. via a Dune RPC call. (ocaml/dune#4522, Andrey Mokhov) - Remove `dune compute`. It was broken and unused (ocaml/dune#4540, @jeremiedimino) - No longer generate an approximate merlin files when computing the ocaml flags fails, for instance because they include the contents of a file that failed to build. This was a niche feature and it was getting in the way of making Dune's core better. (ocaml/dune#4607, @jeremiedimino) - Make Dune display the progress indicator in all output modes except quiet (ocaml/dune#4618, @aalekseyev) - Report accurate process timing information in trace mode (enabled with `--trace-file`) (ocaml/dune#4517, @rgrinberg) - Do not log `live_words` and `free_words` in trace file. This allows using `Gc.quick_stat` which does not scan the heap. (ocaml/dune#4643, @emillon) - Don't let command run by Dune observe the environment variable `INSIDE_EMACS` in order to improve reproducibility (ocaml/dune#4680, @jeremiedimino) - Fix `root_module` when used in public libraries (ocaml/dune#4685, fixes ocaml/dune#4684, @rgrinberg, @craigfe) - Fix `root_module` when used with preprocessing (ocaml/dune#4683, fixes ocaml/dune#4682, @rgrinberg, @craigfe) - Display Coq profile flags in `dune printenv` (ocaml/dune#4767, @ejgallego) - Introduce mdx stanza 0.2, requiring mdx >= 1.9.0, with a new generic `deps` field and the possibility to statically link `libraries` in the test executable. (ocaml/dune#3956, ocaml/dune#5391, fixes ocaml/dune#3955) - Improve lookup of optional or disabled binaries. Previously, we'd treat every executable with missing libraries as optional. Now, we treat make sure to look at the library's optional or enabled_if status (ocaml/dune#4786). - Always use 7 char hash prefix in build info version (ocaml/dune#4857, @jberdine, fixes ocaml/dune#4855) - Allow to explicitly disable/enable the use of `dune subst` by adding a new `(subst <disable|enable>)` stanza to the `dune-project` file. (ocaml/dune#4864, @kit-ty-kate) - Simplify the way `dune` discovers the root of the workspace. It now stops at the first `dune-workspace` file it encounters, and fails if it finds neither a `dune-workspace` nor a `dune-project` file (ocaml/dune#4921, fixes ocaml/dune#4459, @jeremiedimino) - Dune no longer reads installed META files for libraries distributed with the compiler, instead using its own internal database. (ocaml/dune#4946, @nojb) - Add support for `(empty_module_interface_if_absent)` in executable and library stanzas. (ocaml/dune#4955, @nojb) - Add support for `%{bin-available:...}` (ocaml/dune#4995, @jeremiedimino) - Make sure running `git` or `hg` in a sandboxed action, such as a cram test cannot escape the sandbox and pick up some random git or mercurial repository on the file system (ocaml/dune#4996, @jeremiedimino) - Allow `%{read:...}` in more places such as `(enabled_if ...)` (ocaml/dune#4994, @jeremiedimino) - Run each action in its own process group so that we don't leave stray processes behind when killing actions (ocaml/dune#4998, @jeremiedimino) - Add an option `expand_aliases_in_sandbox` (ocaml/dune#5003, @jeremiedimino) - Allow to cancel the initial scan via Control+C (ocaml/dune#4460, fixes ocaml/dune#4364 @jeremiedimino) - Add experimental support for directory targets (ocaml/dune#3316, ocaml/dune#5025, Andrey Mokhov), enabled via `(using directory-targets 0.1)` in `dune-project`. - Delete old `promote-into`, `promote-until-clean` and `promote-until-clean-into` syntax (ocaml/dune#5091, Andrey Mokhov). - Add link_flags in the env stanza (ocaml/dune#5215) - Bootstrap: ignore errors when trying to remove generated files. (ocaml/dune#5407, @damiendoligez)

emillon force-pushed the warn-if-dune-project-does-not-exist branch from 9f04778 to 5cd4c5e Compare January 13, 2022 16:39

emillon requested a review from snowleopard January 13, 2022 16:40

ghost suggested changes Jan 13, 2022

View reviewed changes

src/dune_engine/source_tree.ml Outdated Show resolved Hide resolved

emillon force-pushed the warn-if-dune-project-does-not-exist branch from 5cd4c5e to c43cc75 Compare January 14, 2022 09:07

emillon added this to the 3.0.0 milestone Jan 14, 2022

rgrinberg force-pushed the warn-if-dune-project-does-not-exist branch from ad107a8 to 5d6cab4 Compare February 6, 2022 04:45

emillon commented Feb 7, 2022

View reviewed changes

rgrinberg force-pushed the warn-if-dune-project-does-not-exist branch from af99e5c to 2666896 Compare February 8, 2022 01:35

rgrinberg force-pushed the warn-if-dune-project-does-not-exist branch from d8a5998 to 2e5fc74 Compare February 8, 2022 15:32