Factor out rule targets into a separate module #5048
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactoring in preparation of #5025.
Targets
for representing rule targets. For now, it only represents file targets but the interface is designed to extend the module to support directory targets too. For example, various function arguments are called~file
instead of more usual~f
because directory targets will require a new argument~dir
.Dune_rules.Targets
toDune_rules.Targets_spec
to avoid confusion.The only slight change of behaviour is around pretty printing of targets in an error message in
rule.ml
: it used to simply turn paths into a string but the newTargets.pp
usesDpath.describe_target
as in other places where we pretty print targets.