Skip to content

fix: stop starting rpc with dune promote #13428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgrinberg merged 2 commits into from
Jan 23, 2026
Merged

fix: stop starting rpc with dune promote #13428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba959ff
dev
rgrinberg Dec 31, 2025
badf8b2
fix: stop setting up RPC with dune promote
rgrinberg Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bin/promotion.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ module Apply = struct
let files_to_promote = files_to_promote ~common files in
match Dune_util.Global_lock.lock ~timeout:None with
| Ok () ->
(* Why are we starting an RPC server??? *)
Scheduler_setup.go_with_rpc_server ~common ~config (fun () ->
Scheduler_setup.go_without_rpc_server ~common ~config (fun () ->
let open Fiber.O in
let+ () = Fiber.return () in
let missing =
Expand Down
1 change: 1 addition & 0 deletions doc/changes/changed/13428.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Stop starting RPC server with `$ dune promote` (#13428, @rgrinberg)
Loading