-
Notifications
You must be signed in to change notification settings - Fork 453
Test against Rocq 9.1.0 in CI. #12734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Looks like |
|
Let's try! |
|
Looks like the nix part is working. However as you can see, the test suite will need to be updated which will probably entail a lot of work. I don't mind bumping the coq/rocq version to 9.1 and stopping the testing of 8.16. There is little point of us testing an older version anyway if most potential users are using something else. This PR will likely have to be drafted until the fixes are done. |
Signed-off-by: Rodolphe Lepigre <[email protected]>
|
Yeah, it indeed looks non-trivial... On the other hand, it'd be nice if we could have have the test suite work for both versions for a while, to notice regressions when we move to using the I'll experiment a bit more to see what it would take. If that's too hard, I guess we can just bump to using Rocq 9. |
Signed-off-by: Rodolphe Lepigre <[email protected]>
Signed-off-by: Rodolphe Lepigre <[email protected]>
|
Hi folks, I did look into this back when we were writing #12035 , and indeed it'd be a bit complex. IMHO I prefer to go ahead with #12035 , which will CI against 9.1 , and keep the legacy But if you would like to improve CI for |
I have no idea what I am doing (not a nix user), so help would be appreciated.