Add ‘dune promotion show’ command and tests #12669
Merged
+299
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@ElectreAAS do you want to try reviewing this one? |
ElectreAAS
approved these changes
Nov 6, 2025
Collaborator
ElectreAAS
left a comment
ElectreAAS
left a comment
There was a problem hiding this comment.
This is great!
My only question was: didn't we already have this? isn't this supposed to be what dune promotion diff does?
well apparently not
thanks :)
ElectreAAS
reviewed
Nov 6, 2025
Alizter
reviewed
Nov 6, 2025
Alizter
approved these changes
Nov 12, 2025
Member
|
I'll let @ElectreAAS review or merge this one. |
ElectreAAS
force-pushed
the
feat/add-promotion-show-command
branch
from
218c6ea to
17be9be
Compare
Collaborator
|
I just rebased on main and apparently fucked up something with Github, don't worry I'm on it ;) |
ElectreAAS
requested changes
Nov 17, 2025
ElectreAAS
force-pushed
the
feat/add-promotion-show-command
branch
from
17be9be to
a9b7a5c
Compare
Collaborator
|
Also as this is user-facing, a changes entry would be nice |
Collaborator
|
|
ElectreAAS
approved these changes
Nov 24, 2025
Implements a new command to display corrected file contents without applying the promotion. Users can now view what the promoted file would look like before deciding to promote. - Added 'show' subcommand to bin/promotion.ml - Exposed correction_file function in src/promote/diff_promotion.mli Tests still need to be added. Fixes ocaml#3883 Signed-off-by: Maxence Maury <[email protected]>
Add a new blackbox test to verify the behavior of the 'dune promotion show' command. The test covers common use cases and edge cases to make sure the command works as intended and doesn’t modify source files. It checks that: - corrected files are displayed after failed diffs - multiple files and missing promotions are handled properly - warnings appear for non-promotable or missing files - source files stay untouched after showing their content Signed-off-by: Maxence Maury <[email protected]>
Signed-off-by: Maxence Maury <[email protected]>
Signed-off-by: Ambre Austen Suhamy <[email protected]>
Signed-off-by: Maxence Maury <[email protected]>
ElectreAAS
force-pushed
the
feat/add-promotion-show-command
branch
from
0761581 to
da65ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new subcommand
dune promotion showthat lets usersview the corrected contents of files ready for promotion without modifying
them.
It also adds a blackbox test verifying key behaviors:
Fixes #3883