fix(rpc): handle EINVAL on macOS #12665
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a socket is closed between `accept()` and `setsockopt()` due to a race condition it will raise EINVAL. Ignorance appears to be the usual way of dealing with this on macOS where this problem only occurs. Signed-off-by: Ali Caglayan <[email protected]>
Member
|
I don't know if this is the right fix, but if it is, you should definitely try doing it in OCaml. The less C we have, the better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a socket is closed between
accept()andsetsockopt()due to a race condition it will raise EINVAL. Ignorance appears to be the usual way of dealing with this on macOS where this problem only occurs.Fixes #12660 (?)