dune init: use source path #12601
Merged
dune init: use source path #12601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
dune-init-source-path
branch
from
eabc18c to
48915ce
Compare
Alizter
approved these changes
Oct 20, 2025
Alizter
reviewed
Oct 20, 2025
Signed-off-by: Rudi Grinberg <[email protected]>
Removes unnecesasry as_exn calls. Also needed for a subsequent PR which will require passing the dir to parse the stanzas. Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
force-pushed
the
dune-init-source-path
branch
from
48915ce to
d2458d1
Compare
davesnx
added a commit
to davesnx/dune
that referenced
this pull request
Oct 22, 2025
…without-system * 'main' of github.com:/ocaml/dune: (33 commits) Fix difference between bootstrap & dune behaviour w.r.t include-subdirs ambiguity (ocaml#12607) Revert "Fix difference between bootstrap & dune behaviour w.r.t include-subdirs ambiguity" fix(include-subdirs-qualified): prefer closer module of the same name Add 2 tests showing difference between bootstrap & dune w.r.t include-subdirs dune init: use source path (ocaml#12601) chore(deps): bump actions/setup-node from 5 to 6 test(melange): show melange compilation isn't part of `@all` alias (ocaml#12603) Disable flaky test (ocaml#12600) Rename path to dir in dune_init (ocaml#12599) Dune project: remove dead code (ocaml#12598) Dune_project refactor (ocaml#12597) doc(melange): reference `dirs` stanza (ocaml#12596) Stanza simplifications (ocaml#12595) Reduce stanza definition boilerplate (ocaml#12592) Rename Stanza_common to Stanza_pkg (ocaml#12593) Remove copied code between library and library_parameter stanzas (ocaml#12594) Split modules settings (ocaml#12591) Move the (include_subdirs qualified) check to a single place (ocaml#12590) refactor: simplify loc/ocamllex/ocamlyacc stanza handling (ocaml#12589) pkg: Implement a package search command ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves us from using
as_in_source_tree_exnand also prepares us from passing this directory to the stanza parser.As a side effect, let's fix the issue of turning absolute paths into source paths and allow dune init to work on absolute paths