Skip to content

refactor(boot): replace concat + filter_map with concat_map #12374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2025
Merged

refactor(boot): replace concat + filter_map with concat_map #12374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions boot/duneboot.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1285,24 +1285,24 @@ let convert_dependencies ~all_source_files { Dep.file; deps = dependencies } =
let filename = String.uncapitalize_ascii module_name in
if filename = Filename.chop_extension file
then (* Self-reference *)
None
[]
else if String.Set.mem (filename ^ ".mli") all_source_files
then
if (not is_mli) && String.Set.mem (filename ^ ".ml") all_source_files
then
(* We need to build the .ml for inlining info *)
Some [ filename ^ ".mli"; filename ^ ".ml" ]
[ filename ^ ".mli"; filename ^ ".ml" ]
else (* .mli files never depend on .ml files *)
Some [ filename ^ ".mli" ]
[ filename ^ ".mli" ]
else if String.Set.mem (filename ^ ".ml") all_source_files
then
(* If there's no .mli, then we must always depend on the .ml *)
Some [ filename ^ ".ml" ]
[ filename ^ ".ml" ]
else (* This is a module coming from an external library *)
None
[]
in
let dependencies =
let dependencies = List.concat (List.filter_map ~f:convert_module dependencies) in
let dependencies = List.concat_map ~f:convert_module dependencies in
(* .ml depends on .mli, if it exists *)
if (not is_mli) && String.Set.mem (file ^ "i") all_source_files
then (file ^ "i") :: dependencies
Expand Down
Loading