-
Notifications
You must be signed in to change notification settings - Fork 453
refactor: represent virtual libraries via Lib_kind.t
#12276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0364151 to
7072da7
Compare
shonfeder
commented
Aug 24, 2025
shonfeder
commented
Aug 24, 2025
shonfeder
commented
Aug 24, 2025
rgrinberg
reviewed
Aug 24, 2025
rgrinberg
reviewed
Aug 24, 2025
rgrinberg
reviewed
Aug 24, 2025
cadae32 to
f320a5f
Compare
a1ead07 to
0e163cb
Compare
f6d359c to
7f27f4e
Compare
Member
Author
|
This should be ready for a final review pass. Thank you for the input @Alizter and @rgrinberg! It was very helpful :) |
Signed-off-by: Shon Feder <[email protected]>
Signed-off-by: Shon Feder <[email protected]>
Signed-off-by: Shon Feder <[email protected]>
Signed-off-by: Shon Feder <[email protected]>
Signed-off-by: Shon Feder <[email protected]>
Signed-off-by: Shon Feder <[email protected]>
Signed-off-by: Shon Feder <[email protected]>
Signed-off-by: Shon Feder <[email protected]>
167e29b to
92058cf
Compare
Member
Author
|
This is ready for review again :) |
rgrinberg
reviewed
Aug 25, 2025
rgrinberg
approved these changes
Aug 25, 2025
Signed-off-by: Shon Feder <[email protected]>
Member
Author
|
Thanks for the review and patient guidance! |
Signed-off-by: Shon Feder <[email protected]>
441f143 to
4aea40e
Compare
Signed-off-by: Shon Feder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12253
The refactor here is quite straightforward, with the exception of maintaining backwards compat with current syntax of library stanzas. To achieve this, we infer
kind virtualwhenevervirtual_modulesare specified alongside a compatible kind (normalorvirtual).Two incidental improvements are also suggested here: small fixes to the docs and cleaning up a case analysis handling
ppx_*kinds.TODO
To wrap this up, I need
Reviewing
Initial review by commit is probably helpful, since the commits are broken into a few tiny, distinct phases.