tests: Make dune.lock a configurable location
#12129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that we plan to move the location, this PR makes the location configurable in the helpers script. Signed-off-by: Marek Kubica <[email protected]>
shonfeder
approved these changes
Aug 6, 2025
Member
shonfeder
left a comment
shonfeder
left a comment
There was a problem hiding this comment.
Thank you for breaking the mechanical changes into this easy to review change! 🙏
Sudha247
approved these changes
Aug 6, 2025
Collaborator
Sudha247
left a comment
Sudha247
left a comment
There was a problem hiding this comment.
I chatted offline with @Leonidas-from-XIV a bit about this, and for context this change makes the diff in #11775 in smaller. I'm happy with merging this as is, with a minor note below.
Sudha247
reviewed
Aug 6, 2025
gridbugs
approved these changes
Aug 6, 2025
Member
|
Alternatively, you could also introduce a shell function to this operation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we plan to move the location, this PR makes the location configurable in the helpers script.