[3.17] remove breaking change for alpha1
#11164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormatting wrapped lists (ocaml#10892)" This reverts commit af95981. Signed-off-by: Etienne Marais <[email protected]>
Signed-off-by: Etienne Marais <[email protected]>
maiste
force-pushed
the
prepare-3.17/remove-breaking-change
branch
from
39d6b41 to
d818c2d
Compare
Leonidas-from-XIV
approved these changes
Nov 27, 2024
ElectreAAS
approved these changes
Nov 27, 2024
This was referenced Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the patch made in #10892 for the
3.17.0~alpha1release. Indeed, while releasing3.17.0we have seen that it would breakodoctests because of the indentation. Further discussions have occurred in the PR about how to fix it inmainin a more sustainable way. However, we have decided to remove the patch for3.17.0and reintroduce it in later released.