Skip to content

fix: Do not depend on dune in dune-project in dune init template #11129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: Do not depend on dune in dune-project in dune init template #11129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bin/dune_init.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,6 @@ module Component = struct
[ { Package_dependency.name = Package.Name.of_string "ocaml"
; constraint_ = None
}
; { name = Package.Name.of_string "dune"; constraint_ = None }
]
in
let packages = Package.Name.Map.singleton (Package.name package) package in
Expand Down
8 changes: 4 additions & 4 deletions test/blackbox-tests/test-cases/dune-init.t/run.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ In particular, the `dune-project` file has the expected content:
(name new_exec_proj)
(synopsis "A short synopsis")
(description "A longer description")
(depends ocaml dune)
(depends ocaml)
(tags
("add topics" "to describe" your project)))

Expand All @@ -384,8 +384,8 @@ And the opam file will be generated as expected
doc: "https://url/to/documentation"
bug-reports: "https://github.com/username/reponame/issues"
depends: [
"ocaml"
$dune {>= "3.17"}
"ocaml"
"odoc" {with-doc}
]
build: [
Expand Down Expand Up @@ -467,7 +467,7 @@ In particular, the `dune-project` file has the expected content:
(name new_lib_proj)
(synopsis "A short synopsis")
(description "A longer description")
(depends ocaml dune)
(depends ocaml)
(tags
("add topics" "to describe" your project)))

Expand All @@ -494,8 +494,8 @@ And the opam file will be generated as expected
doc: "https://url/to/documentation"
bug-reports: "https://github.com/username/reponame/issues"
depends: [
"ocaml"
"dune" {>= "3.17"}
"ocaml"
"odoc" {with-doc}
]
build: [
Expand Down
Loading