Skip to content

Encourage adding email in author & maintainer info #10848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Encourage adding email in author & maintainer info #10848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dune_lang/package_info.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ let example =
{ source =
Some (Host (Source_kind.Host.Github { user = "username"; repo = "reponame" }))
; license = Some [ "LICENSE" ]
; authors = Some [ "Author Name" ]
; maintainers = Some [ "Maintainer Name" ]
; authors = Some [ "Author Name <[email protected]>" ]
; maintainers = Some [ "Maintainer Name <[email protected]>" ]
; documentation =
Some "https://url/to/documentation"
(* homepage and bug_reports are inferred from the source *)
Expand Down
16 changes: 8 additions & 8 deletions test/blackbox-tests/test-cases/dune-init.t/run.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,9 +345,9 @@ In particular, the `dune-project` file has the expected content:
(source
(github username/reponame))

(authors "Author Name")
(authors "Author Name <[email protected]>")

(maintainers "Maintainer Name")
(maintainers "Maintainer Name <[email protected]>")

(license LICENSE)

Expand Down Expand Up @@ -376,8 +376,8 @@ And the opam file will be generated as expected
opam-version: "2.0"
synopsis: "A short synopsis"
description: "A longer description"
maintainer: ["Maintainer Name"]
authors: ["Author Name"]
maintainer: ["Maintainer Name <[email protected]>"]
authors: ["Author Name <[email protected]>"]
license: "LICENSE"
tags: ["topics" "to describe" "your" "project"]
homepage: "https://github.com/username/reponame"
Expand Down Expand Up @@ -455,9 +455,9 @@ In particular, the `dune-project` file has the expected content:
(source
(github username/reponame))

(authors "Author Name")
(authors "Author Name <[email protected]>")

(maintainers "Maintainer Name")
(maintainers "Maintainer Name <[email protected]>")

(license LICENSE)

Expand Down Expand Up @@ -486,8 +486,8 @@ And the opam file will be generated as expected
opam-version: "2.0"
synopsis: "A short synopsis"
description: "A longer description"
maintainer: ["Maintainer Name"]
authors: ["Author Name"]
maintainer: ["Maintainer Name <[email protected]>"]
authors: ["Author Name <[email protected]>"]
license: "LICENSE"
tags: ["topics" "to describe" "your" "project"]
homepage: "https://github.com/username/reponame"
Expand Down