Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make find_binding match annotated declarations #425

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Conversation

hferee
Copy link

@hferee hferee commented Sep 27, 2021

Fixes #424

Copy link
Member

@erikmd erikmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hferee for opening #424 then proposing a patch!

Could you rename your PR title so that it is more descriptive? (it's enough if the Fixes #424 string is only in the commit message or PR description; while the PR title will appear in the Merge commit and should be self-contained)

@yurug do you know whether it'd be necessary to add a small test here: https://github.com/ocaml-sf/learn-ocaml/tree/master/tests ?

At first sight, I'd say no… (as no risk of regression is expected 😅)

@yurug
Copy link
Collaborator

yurug commented Sep 27, 2021

@yurug do you know whether it'd be necessary to add a small test here: https://github.com/ocaml-sf/learn-ocaml/tree/master/tests ?
At first sight, I'd say no… (as no risk of regression is expected )

That would not hurt: @hferee, would you mind doing it, please?

@erikmd erikmd added the kind: enhancement Enhancement to an existing user-facing feature. label Sep 27, 2021
@hferee hferee changed the title Fixes ocaml-sf/learn-ocaml#424 Make find_binding match annotated declarations Sep 28, 2021
@hferee
Copy link
Author

hferee commented Sep 28, 2021

That would not hurt: @hferee, would you mind doing it, please?

Here you go! Please let me know if more tests are necessary.

@yurug
Copy link
Collaborator

yurug commented Sep 28, 2021

Thanks!

@erikmd
Copy link
Member

erikmd commented Sep 28, 2021

Thanks @hferee! LGTM as well. So let's merge your PR after setting its milestone to 0.13.

@erikmd erikmd added this to the learn-ocaml 0.13 milestone Sep 28, 2021
@erikmd erikmd merged commit b277b38 into ocaml-sf:master Sep 28, 2021
@erikmd
Copy link
Member

erikmd commented Sep 28, 2021

BTW @hferee, you may want to checkout the page https://github.com/settings/emails
to see if your e-mail feree(AT)irif(DOT)fr could be added there.

Otherwise, GitHub is currently unable to associate your commits and your user account:
2021-09-28_19-56-30_Screenshot_Hugo_commit_email

But if you fix this, you'll see your name appear in https://github.com/ocaml-sf/learn-ocaml/graphs/contributors

@hferee
Copy link
Author

hferee commented Sep 29, 2021

BTW @hferee, you may want to checkout the page https://github.com/settings/emails to see if your e-mail feree(AT)irif(DOT)fr could be added there.

Otherwise, GitHub is currently unable to associate your commits and your user account: 2021-09-28_19-56-30_Screenshot_Hugo_commit_email

But if you fix this, you'll see your name appear in https://github.com/ocaml-sf/learn-ocaml/graphs/contributors

Well, sure. Not that I'm doing this for fame 😄

@yurug
Copy link
Collaborator

yurug commented Sep 29, 2021

Well, sure. Not that I'm doing this for fame smile

The honor is on our side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Enhancement to an existing user-facing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Make find_binding match annotated declarations
3 participants