Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: partition-view is unavailable on macOS #500

Closed
erikmd opened this issue Nov 18, 2022 · 1 comment · Fixed by #516, #511 or ocaml/opam-repository#24305
Closed

Bug: partition-view is unavailable on macOS #500

erikmd opened this issue Nov 18, 2022 · 1 comment · Fixed by #516, #511 or ocaml/opam-repository#24305
Assignees

Comments

@erikmd
Copy link
Member

erikmd commented Nov 18, 2022

Related project scope(s): UI

Related user(s): @erikmd et al.

Bug description

In the teacher dashboard, the partition-view feature being triggered by a middle-click, macOS users can't use it.

To reproduce

As described above.

Additional context

@yurug
Copy link
Collaborator

yurug commented Nov 18, 2022

One possible fix is to replace middle-click with ctrl+click : https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/ctrlKey#browser_compatibility

erikmd added a commit that referenced this issue Mar 12, 2023
…ck) (#516)

This new key-binding is macOS-compliant (tested with both Firefox and Safari).

Close #500

Co-authored-by: Yann Regis-Gianas <[email protected]>
Co-authored-by: Érik Martin-Dorel <[email protected]>
@erikmd erikmd added this to the learn-ocaml 1.0.0 milestone Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment