Fix Ast_builder's value_binding to generate the correct pvb_constraint
#589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
requested review from
ceastlund,
panglesd,
patricoferris and
pitag-ha
as code owners
Collaborator
Author
|
I couldn't figure out a proper test for the coercion case and I suspect the logic to convert coercion expression is faulty or at the very least too restrictive. I'm marking this as ready for review as I don't have a lot of time to spend on ppxlib atm and would still like to be able to release 0.36.2 and 0.37 shortly. I'll open an issue regarding the conversion to the coercion constraint! |
NathanReb
force-pushed
the
ast-builder-ppat-constraint-to-pvb-constraint
branch
from
e516f47 to
c5ec60f
Compare
Collaborator
Author
|
Actually I just need to factor out the code between the migration and Ast_builder so that they share the |
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
ast-builder-ppat-constraint-to-pvb-constraint
branch
from
c5ec60f to
300f724
Compare
Collaborator
Author
|
Nevermind, it can't easily be shared as they're manipulating different types. It's probably not worth investing too much time on functorizing this just to share that bit of code. This is ready for review if anyone has spare cycles. I'll fix the coercion case later on as this would already be very valuable to release. |
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
ast-builder-ppat-constraint-to-pvb-constraint
branch
from
5c44b95 to
8bb5ce1
Compare
added 2 commits
September 25, 2025 16:05
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
ast-builder-ppat-constraint-to-pvb-constraint
branch
from
8bb5ce1 to
6ac0849
Compare
NathanReb
pushed a commit
to NathanReb/opam-repository
that referenced
this pull request
Oct 1, 2025
CHANGES: - Make Ast_builder's default `value_binding` constructor generate the proper `pvb_constraint` from the pattern and expression arguments. (ocaml-ppx/ppxlib#589, @NathanReb) - Fix pprintast to output correct syntax from `Ppat_constraint (pat, Ptyp_poly ...)` nodes until they are completely dropped. (ocaml-ppx/ppxlib#588, @NathanReb)
NathanReb
pushed a commit
to NathanReb/opam-repository
that referenced
this pull request
Oct 1, 2025
CHANGES: - Make Ast_builder's default `value_binding` constructor generate the proper `pvb_constraint` from the pattern and expression arguments. (ocaml-ppx/ppxlib#589, @NathanReb) - Fix pprintast to output correct syntax from `Ppat_constraint (pat, Ptyp_poly ...)` nodes until they are completely dropped. (ocaml-ppx/ppxlib#588, @NathanReb)
mtelvers
pushed a commit
to mtelvers/opam-repository
that referenced
this pull request
Oct 1, 2025
CHANGES: - Make Ast_builder's default `value_binding` constructor generate the proper `pvb_constraint` from the pattern and expression arguments. (ocaml-ppx/ppxlib#589, @NathanReb) - Fix pprintast to output correct syntax from `Ppat_constraint (pat, Ptyp_poly ...)` nodes until they are completely dropped. (ocaml-ppx/ppxlib#588, @NathanReb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add some basic tests for this before we merge but it's basically a copy of the code that's handling the same conversion in the 5.0 -> 5.1 migration.