Declare show's with_path argument for interface deriver as well#277
Merged
NathanReb merged 2 commits intoocaml-ppx:masterfrom Mar 14, 2024
Merged
Declare show's with_path argument for interface deriver as well#277NathanReb merged 2 commits intoocaml-ppx:masterfrom
show's with_path argument for interface deriver as well#277NathanReb merged 2 commits intoocaml-ppx:masterfrom
Conversation
Even though the argument is unused in `.mli` files as it only affects the implementation and not the signature of the function, it used to be accepted back when declared via `ppx_deriving.api` so we need to keep it that way for compatibility. Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Collaborator
Author
|
cc @sim642. This should fix a lot of the errors we got in ocaml/opam-repository#25458. |
Contributor
|
Heh, I also started a fix: 8d6b749. Turns out one needs to bypass the value restriction to get it to compile. |
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Collaborator
Author
|
Argh yeah just realized that! I pushed a fix just now! |
Collaborator
Author
|
@gasche do you want to give this one a look or should I go ahead and merge? |
Collaborator
|
If it fixes the packages in opam-repository I think you can just merge it |
sim642
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though the argument is unused in
.mlifiles as it only affects the implementation and not the signature of the function, it used to be accepted back when declared viappx_deriving.apiso we need to keep it that way for compatibility.