Skip to content

Update ppx_deriving.cppo.mli#268

Open
marrious11 wants to merge 1 commit intoocaml-ppx:masterfrom
marrious11:patch-1
Open

Update ppx_deriving.cppo.mli#268
marrious11 wants to merge 1 commit intoocaml-ppx:masterfrom
marrious11:patch-1

Conversation

@marrious11
Copy link

Added a deprecation signature to https://github.com/ocaml-ppx/ppx_deriving/edit/master/src/api/ppx_deriving.cppo.mli#L48.
Sir @panglesd, please let me know if the modifications I am doing is not right. Though, I find it difficult to locate the exact lines of code to modify as supposed to roddyyaga/ppx_rapper#29.
Signed-off-by: Mario 66856309+marrious11@users.noreply.github.com

Added a deprecation signature to<https://github.com/ocaml-ppx/ppx_deriving/edit/master/src/api/ppx_deriving.cppo.mli#L48>
Sir @panglesd, please let me know if what I am doing is not right
Signed-off-by: Mario <66856309+marrious11@users.noreply.github.com>
@panglesd
Copy link
Contributor

panglesd commented Mar 27, 2023

Hello @marrious11!

Though, I find it difficult to locate the exact lines of code to modify as supposed to roddyyaga/ppx_rapper#29.

I'll help you on this in the issue thread! (actually, by email)

This repository is the one of a different project, ppx_deriving, which contains useful derivers, as well as several helpers to write your own deriver. However, currently the recommended way to register derivers has been to use ppxlib, hence the discussion whether to deprecate some of ppx_deriving API in #263.

However, deprecating (or not) ppx_deriving API is not really related to roddyyaga/ppx_rapper#29!

@marrious11
Copy link
Author

😞 alright sir @panglesd. Thank you for the redirect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants