Add a --no-confirmation option

[AltGr]

This might be required for some complex release pipelines where the package is already guaranteed to be well reviewed and checked before opam-publish is called.

I took care to add some safeguards to avoid copy-paste of ill-advised one-liners that would result in people submitting unreviewed releases and increasing the strain on the repository maintainers.

[AltGr]

Closes #132

[kit-ty-kate]

Thanks

[MisterDA]

Could you explain why that different from OPAMYES=1 or a simple -y option? Other examples may include pacman's --noconfirm, apt-get's DEBIAN_FRONTEND=noninteractive, pip's --yes or --no-input.
EDIT: is it just because we're in a plugin, and that would collide with opam?

[kit-ty-kate]

Could you explain why that different from OPAMYES=1 or a simple -y option?

OPAMYES is not supported by opam-publish, and in my opinion, does not provide an acceptable interface for such a dangerous option. It wouldn’t be a good option for currently existing docker images for example where OPAMYES is already set to true, so if someone were to run opam-publish in it, it would skip all the manual verification necessary.
Also, being an environment variable makes it hard to make sure accidental publishing doesn’t happen.

-y is too short and obscure as to its behaviour in my opinion for that particular case. It’s fine for lower stake actions but automated publishing is something else.

--no-confirmation is long enough that users should think twice about copy-pasting code that contains it and explicit enough for anyone reading it to know what it’s going to do.

[erikmd]

Dear all, thanks a lot for implementing this 👍👍

Just a small question to opam-publish maintainers: do you think this enhancement would deserve a release?

(otherwise, no worries: users could just as well do some opam git pin to benefit from it meanwhile)

Thanks!

[AltGr]

@erikmd definitely, we'll do a release

[kit-ty-kate]

@erikmd done: ocaml/opam-repository#24714