Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take out unused line #904

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Take out unused line #904

merged 2 commits into from
Mar 11, 2022

Conversation

romefeller
Copy link
Contributor

Obelisk.Frontend breaks when using lens 5.1.

The line 66 (makePrisms ''Sum) of Obelisk.Frontend was unused and was causing compilations errors.
The corresponding import (Data.Functor.Sum) was also taken out.

The line was taken out since it was unused.

I have:

  • [ x] Based work on latest develop branch
  • [ x] Followed the contribution guide
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
  • [ X] Run the test suite: $(nix-build -A selftest --no-out-link)
  • Updated the changelog
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

@romefeller romefeller changed the base branch from master to develop March 11, 2022 18:32
@romefeller romefeller requested review from alexfmpe, Yasuke, Ericson2314, danbornside and madeline-os and removed request for alexfmpe March 11, 2022 18:41
@romefeller romefeller changed the base branch from develop to so/ghc8_10-wip-mime March 11, 2022 19:33
@romefeller romefeller changed the base branch from so/ghc8_10-wip-mime to develop March 11, 2022 19:43
@Ericson2314 Ericson2314 merged commit fbe92c1 into develop Mar 11, 2022
jrpotter pushed a commit that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants