Test higher-arity type constructors #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Unfortunately now that #53 is merged, this has a lot of conflicts. |
Contributor
|
Well, #53 should also fix the issue (if it doesn't let me know of course) |
Member
|
Indeed it does. I rebase this just making it a rest. I suppose I can check whether that test is redundant, too. |
Ericson2314
force-pushed
the
derive-higher-arity
branch
from
567e240 to
9844a02
Compare
Member
|
I think the test is legit. |
Ericson2314
changed the title
Contributor
|
Agreed, let's keep the test :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some arity kind error when trying to use a
MyGadt a :: * -> *, and this seems to make the kinds line up, though I'm not sure if it's the right fix. ThemakeClassHeadparameter doesn't seem the right way to go about it, but that's forDataD. I'm not so sure about the otherDeccases. For instance, I don't get the intent forInstanceDat all - we're modifying instances?